[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kolourpaint/pixmapfx (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2007-10-20 2:24:54
Message-ID: 1192847094.641771.26368.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 727232 by dang:

SVN_SILENT +convertToImage() warning


 M  +17 -0     kppixmapfx.h  


--- branches/KDE/3.5/kdegraphics/kolourpaint/pixmapfx/kppixmapfx.h #727231:727232
@@ -93,6 +93,23 @@
     //
     // Converts <pixmap> to a QImage and returns it.
     //
+    // WARNING: On an 8-bit screen:
+    //
+    //              QPixmap result = convertToPixmap (convertToImage (pixmap));
+    //
+    //          <result> is slightly differently colored to <pixmap>.
+    //
+    //          KolourPaint needs to convert to QImage occasionally as
+    //          QImage allows KolourPaint to read pixels and because the QImage
+    //          methods give reliable results and pixel-identical results on
+    //          all platforms.  The QPixmap paint engine has no such guarantee
+    //          and even depends on the quality of the video driver.
+    //
+    //          As a result, KolourPaint should not be used on an 8-bit screen.
+    //          HITODO: Add warning on startup, like in KolourPaint/KDE4.
+    //
+    //          This bug will be fixed when KolourPaint gets a proper image library,
+    //          where QPixmap -> QImage -> QPixmap transitions will be not be needed.
     static QImage convertToImage (const QPixmap &pixmap);
 
     //
[prev in list] [next in list] [prev in thread] [next in thread]