[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kolourpaint (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2007-10-07 10:41:33
Message-ID: 1191753693.646469.27230.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 722445 by dang:

SVN_SILENT Add bugs #27 and #28 from trunk/


 M  +5 -0      BUGS  
 M  +2 -0      kpselection.cpp  
 M  +12 -0     kpviewmanager.cpp  


--- branches/KDE/3.5/kdegraphics/kolourpaint/BUGS #722444:722445
@@ -122,7 +122,12 @@
     not drawing or KolourPaint may fail to detect the release of the Enter
     key.
 
+27. InputMethod has not been tested at zoom levels other than 100%.
 
+28. KolourPaint has not been tested against invalid or malicious clipboard
+    data.
+
+
 Issue with XFree86 <= 3.3.6 with the "Emulate3Buttons" Option
 =============================================================
 
--- branches/KDE/3.5/kdegraphics/kolourpaint/kpselection.cpp #722444:722445
@@ -200,6 +200,8 @@
 }
 
 // public
+// TODO: KolourPaint has not been tested against invalid or malicious
+//       clipboard data [Bug #28].
 void kpSelection::readFromStream (QDataStream &stream,
                                   const kpPixmapFX::WarnAboutLossInfo &wali)
 {
--- branches/KDE/3.5/kdegraphics/kolourpaint/kpviewmanager.cpp #722444:722445
@@ -356,6 +356,18 @@
             QPoint topLeft = sel->pointForTextRowCol (m_textCursorRow, \
m_textCursorCol);  if (topLeft != KP_INVALID_POINT)
             {
+                // TODO: I think you need to consider zooming e.g. try editing
+                //       text at 800% or with focus set to the thumbnail.
+                //       kpSelection/kpDocument works fully in unzoomed 
+                //       coordinates unlike the view (which is zoomed and can
+                //       change size).
+                //
+                //       To fix it here, I think you should call
+                //       m_viewUnderCursor->transformDocToView(QRect).  However,
+                //       the rest of the InputMethod support still needs to
+                //       audited for this.
+                //
+                //       [Bug #27]
                 m_viewUnderCursor->updateMicroFocusHint(QRect (topLeft.x (), \
topLeft.y (), 1, sel->textStyle ().fontMetrics ().height ()));   }
         }


[prev in list] [next in list] [prev in thread] [next in thread]