[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kolourpaint (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2007-10-05 7:23:18
Message-ID: 1191568998.308198.8031.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 721398 by dang:

SVN_SILENT fix comments


 M  +10 -1     dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp  
 M  +2 -2      imagelib/effects/kpEffectReduceColors.cpp  


--- trunk/KDE/kdegraphics/kolourpaint/dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp \
#721397:721398 @@ -383,7 +383,16 @@
              this, SLOT (slotHeightChanged (int)));
 
     // COMPAT: KDoubleNumInput only fires valueChanged(double) once per
-    //         edit, not once per keystroke.  Bug in KDoubleNumInput.
+    //         edit.  It should either fire:
+    //        
+    //             1. At the end of the edit (triggered by clicking or tabbing
+    //                away), like with KDE3.
+    //
+    //             OR
+    //
+    //             2. Once per keystroke.
+    //
+    //         Bug in KDoubleNumInput.
     connect (m_percentWidthInput, SIGNAL (valueChanged (double)),
              this, SLOT (slotPercentWidthChanged (double)));
     connect (m_percentHeightInput, SIGNAL (valueChanged (double)),
--- trunk/KDE/kdegraphics/kolourpaint/imagelib/effects/kpEffectReduceColors.cpp \
#721397:721398 @@ -95,8 +95,8 @@
 #endif
 
 
-    // Hack around Qt's braindead QImage::convertDepth(1, ...) (with
-    // dithering off) which produces pathetic results with an image that
+    // Hack around Qt's braindead QImage::convertToFormat(QImage::Format_MonoLSB, \
...) +    // (with dithering off) which produces pathetic results with an image that
     // only has 2 colors - sometimes it just gives a completely black
     // result (try yellow and white as input).  Instead, we simply preserve
     // the 2 colours.


[prev in list] [next in list] [prev in thread] [next in thread]