[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kolourpaint (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2007-09-29 11:13:22
Message-ID: 1191064402.697303.6493.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 718634 by dang:

SVN_SILENT Fix & expand TODO


 M  +6 -1      kpViewScrollableContainer.cpp  


--- trunk/KDE/kdegraphics/kolourpaint/kpViewScrollableContainer.cpp #718633:718634
@@ -706,7 +706,7 @@
 #endif
 
 
-// TODO: If XRENDER is disabled, this painting with Qt::WA_PaintOutsidePaintEvent
+// TODO: If XRENDER is disabled, this painting with Qt::WA_PaintUnclipped
 //       seems to trigger a harmless, asynchronous error:
 //
 //           X Error: RenderBadPicture (invalid Picture parameter) 180
@@ -716,6 +716,11 @@
 //
 //       I don't know what code is _directly_ triggering that error -- running
 //       KolourPaint with "-sync" doesn't seem to make the error synchronous.
+//
+//       The API doc for Qt::WA_PaintUnclipped says "This flag is only
+//       supported for widgets for which the WA_PaintOnScreen".  We don't
+//       actually enable "WA_PaintOnScreen" (which looks quite scary), so that
+//       might be part of the cause.
 #define FILL_NOT_RECT(rect)                                              \
     kpPixmapFX::widgetFillNOTRect (viewport (),                          \
         rect.x (), rect.y (), rect.width (), rect.height (),             \
[prev in list] [next in list] [prev in thread] [next in thread]