[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kolourpaint/widgets/toolbars
From:       Clarence Dang <dang () kde ! org>
Date:       2007-09-27 11:00:48
Message-ID: 1190890848.522262.17865.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 717715 by dang:

Document intention to keep the Tool Box and Color Box as QDockWidget's in the long-term.


 M  +3 -0      kpColorToolBar.h  
 M  +4 -1      kpToolToolBar.h  


--- trunk/KDE/kdegraphics/kolourpaint/widgets/toolbars/kpColorToolBar.h #717714:717715
@@ -55,6 +55,9 @@
 //
 //         A nice must-have side-effect is that we are now resizeable, which
 //         is good for configurable (and potentially large) color collections.
+//         So we should probably keep it as a QDockWidget in the long-term
+//         and once we fix orientation and undocking, we should put XMLGUI
+//         support back in, somehow (create a "KDockWidget" class?).
 class kpColorToolBar : public QDockWidget
 {
 Q_OBJECT
--- trunk/KDE/kdegraphics/kolourpaint/widgets/toolbars/kpToolToolBar.h #717714:717715
@@ -55,7 +55,10 @@
 //         so kpMainWindow::init() keeps this tool bar in a constant position for
 //         the time being.  To help make this workaround possible, we use QDockWidget,
 //         instead of KToolBar, to prevent XMLGUI from managing the tool
-//         bar position.  This also allows us to use QMainWindow::setCorner().
+//         bar position.  This also allows us to use QMainWindow::setCorner(),
+//         so we should probably keep it as a QDockWidget in the long-term
+//         and once we fix orientation and undocking, we should put XMLGUI
+//         support back in, somehow (create a "KDockWidget" class?).
 class kpToolToolBar : public QDockWidget
 {
 Q_OBJECT
[prev in list] [next in list] [prev in thread] [next in thread]