[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kolourpaint/lgpl/generic
From:       Clarence Dang <dang () kde ! org>
Date:       2007-09-25 1:13:57
Message-ID: 1190682837.512362.32066.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 716613 by dang:

kpColorCellsBase [fork of KColorCells] enhancements:

* Make <rows> and <columns> default to 0 in ctor
* Override methods to keep d->colors[] in sync with QTableWidget changes:
  - clear(), clearContents()
  - setColumnCount(), setRowCount()
    [now you can safely call these to change the table properties]
  - Add helpers: invalidateAllColors(), setRowColumnCounts()

* Drag-and-drop changes:
  - Defaults to swapping colors
  - CTRL restores the old behavior of overwriting colors
  - Abort drop to cell without a widget or not a cell at all [bug in KColorCells?]  
  - Avoid NOP drag-and-drop

* Change behavior and establish new invariant: a color is the colors array
  is invalid iff the cells' widget does not exist (this changes the behavior
  of setColor() subtlely)
  - You can double click on cells that don't contain a widget
  - You can drop onto -- but not drag a -- cell that doesn't contain a widget
  - internal positionToCell() now supports an extra arg <allowEmptyCell>

* Add setCellsResizeable() to configure the default of behavior of
  whether component cells should resize with the entire widget.

* Emit an extra colorSelected() overload, specifying the button pressed

* Add colorChanged() signal (for when setColor() is called)

* Gray out the cells, when the widget is disabled (intercepting changeEvent())

* Remove Java-inspired colors[] array init in ctor (C++ doesn't need it)

* Style, comments, TODO

You probably won't see most of the changes in action until the next commit to
kpColorCells (which is derived from us, kpColorCellsBase).


 M  +231 -32   kpColorCellsBase.cpp  
 M  +72 -4     kpColorCellsBase.h  


[prev in list] [next in list] [prev in thread] [next in thread]