[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kolourpaint/widgets/toolbars
From:       Clarence Dang <dang () kde ! org>
Date:       2007-09-23 4:32:52
Message-ID: 1190521972.466079.21405.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 715741 by dang:

Better explanation of why the toolbars are using QDockWidget.  Use COMPAT.


 M  +7 -6      kpColorToolBar.h  
 M  +6 -4      kpToolToolBar.h  


--- trunk/KDE/kdegraphics/kolourpaint/widgets/toolbars/kpColorToolBar.h #715740:715741
@@ -47,13 +47,14 @@
 class kpDualColorButton;
 
 
-// TODO: For now, vertical orientation and undocking are broken.
-//       We use QDockWidget, instead of KToolBar, to prevent KMainWindow from
-//       managing tool bar position and to also allow the use of
-//       QMainWindow::setCorner().
+// COMPAT: Vertical orientation and undocking were broken by the Qt4 port
+//         so kpMainWindow::init() fixes this tool bar's position for the
+//         time being.  To help make this workaround possible, we use QDockWidget,
+//         instead of KToolBar, to prevent XMLGUI from managing the tool
+//         bar position.  This also allows us to use QMainWindow::setCorner().
 //
-//       A nice must-have side-effect is that we are now resizeable, which
-//       is good for configurable (and potentially large) color collections.
+//         A nice must-have side-effect is that we are now resizeable, which
+//         is good for configurable (and potentially large) color collections.
 class kpColorToolBar : public QDockWidget
 {
 Q_OBJECT
--- trunk/KDE/kdegraphics/kolourpaint/widgets/toolbars/kpToolToolBar.h #715740:715741
@@ -51,10 +51,12 @@
 class kpToolWidgetSpraycanSize;
 
 
-// TODO: For now, horizontal orientation and undocking are broken.
-//       We use QDockWidget, instead of KToolBar, to prevent KMainWindow from
-//       managing tool bar position and to also allow the use of
-//       QMainWindow::setCorner().
+
+// COMPAT: Vertical orientation and undocking were broken by the Qt4 port
+//         so kpMainWindow::init() fixes this tool bar's position for the
+//         time being.  To help make this workaround possible, we use QDockWidget,
+//         instead of KToolBar, to prevent XMLGUI from managing the tool
+//         bar position.  This also allows us to use QMainWindow::setCorner().
 class kpToolToolBar : public QDockWidget
 {
 Q_OBJECT
[prev in list] [next in list] [prev in thread] [next in thread]