[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/html
From:       Maks Orlovich <maksim () kde ! org>
Date:       2007-09-08 16:27:23
Message-ID: 1189268843.057636.16495.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 709935 by orlovich:

Work around apparent QString bug: its append-to-shared-null 
optimization is wrong if the RHS string was created 
using ::fromRawData, and hence can not guarantee that 
the livetime of the data is any longer than the livetime 
of the shallow wrapper... (Now where is a Troll when you need one?)

Fixes events/frame.onload.html


 M  +1 -1      html_elementimpl.cpp  


--- trunk/KDE/kdelibs/khtml/html/html_elementimpl.cpp #709934:709935
@@ -453,7 +453,7 @@
 
 DOMString HTMLElementImpl::innerHTML() const
 {
-    QString result; //Use QString to accumulate since DOMString is poor for appends
+    QString result = ""; //Use QString to accumulate since DOMString is poor for appends
     for (NodeImpl *child = firstChild(); child != NULL; child = child->nextSibling()) {
         DOMString kid = child->toString();
         result += QString::fromRawData(kid.unicode(), kid.length());
[prev in list] [next in list] [prev in thread] [next in thread]