[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeprint/kdeprintd [POSSIBLY UNSAFE]
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2007-09-05 22:33:33
Message-ID: 20070905223333.GA3741 () ugly ! local
[Download RAW message or body]

On Wed, Sep 05, 2007 at 09:22:57PM +0000, Alex Merry wrote:
> SVN commit 708863 by alexmerry:
> 
> --- trunk/KDE/kdelibs/kdeprint/kdeprintd/kdeprintd.cpp #708862:708863
  
> @@ -47,39 +49,41 @@
  
> +void KPrintProcess::slotReadStandardError()
>  {
> +	QByteArray	str = readAllStandardError().trimmed();
>  	m_buffer.append(QString::fromLocal8Bit(str.append("\n")));
>
the usual mistake: theoretically, this can tear apart multibyte
sequences.
hmm, actually, the appending of a newline is even weirder. oh, well.

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]