[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: KDE/kdelibs/kdeprint
From: Alex Merry <huntedhacker () tiscali ! co ! uk>
Date: 2007-09-05 15:15:58
Message-ID: 1189005358.939877.26081.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 708756 by alexmerry:
Follow the convention of several other libraries in kdelibs,
and denote internal (ie: no exported classes or methods, and not
installed) headers with _p at the end of their name.
I've also removed the #warnings about changing the name from these,
although I'll still put them in the KPrintInternal namespace for
those cases where we don't have visibility control for whatever reason.
M +1 -1 driver.cpp
M +1 -1 driveritem.cpp
D driveritem.h
A driveritem_p.h driveritem.h#708686 [License: LGPL (v2)]
M +2 -2 driverview.cpp
M +2 -2 droptionview.cpp
D droptionview.h
A droptionview_p.h droptionview.h#708686 [License: LGPL (v2)]
M +1 -1 kfilelist.cpp
D kfilelist.h
A kfilelist_p.h kfilelist.h#708686 [License: LGPL (v2)]
M +1 -1 kmjobmanager.cpp
M +2 -2 kmmanager.cpp
M +1 -1 kmspecialmanager.cpp
D kmspecialmanager.h
A kmspecialmanager_p.h kmspecialmanager.h#708686 [License: LGPL (v2)]
M +1 -1 kmthreadjob.cpp
D kmthreadjob.h
A kmthreadjob_p.h kmthreadjob.h#708686 [License: LGPL (v2)]
M +4 -4 kmuimanager.cpp
M +2 -2 kpfileselectpage.cpp
D kpfileselectpage.h
A kpfileselectpage_p.h kpfileselectpage.h#708686 [License: LGPL (v2)]
M +1 -1 kpfilterpage.cpp
D kpfilterpage.h
A kpfilterpage_p.h kpfilterpage.h#708686 [License: LGPL (v2)]
M +1 -1 kpmarginpage.cpp
D kpmarginpage.h
A kpmarginpage_p.h kpmarginpage.h#708686 [License: LGPL (v2)]
M +2 -2 kpposterpage.cpp
D kpposterpage.h
A kpposterpage_p.h kpposterpage.h#708686 [License: LGPL (v2)]
M +1 -1 kprintdialog.cpp
M +1 -1 kprinter.cpp
M +2 -2 kprinterimpl.cpp
M +1 -1 kprintpreview.cpp
D kprintpreview.h
A kprintpreview_p.h kprintpreview.h#708686 [License: LGPL (v2)]
M +1 -1 marginpreview.cpp
D marginpreview.h
A marginpreview_p.h marginpreview.h#708686 [License: LGPL (v2)]
M +1 -1 marginvaluewidget.cpp
D marginvaluewidget.h
A marginvaluewidget_p.h marginvaluewidget.h#708686 [License: LGPL (v2)]
M +2 -2 marginwidget.cpp
M +1 -1 posterpreview.cpp
D posterpreview.h
A posterpreview_p.h posterpreview.h#708686 [License: LGPL (v2)]
M +1 -1 printerfilter.cpp
D printerfilter.h
A printerfilter_p.h printerfilter.h#708686 [License: LGPL (v2)]
M +1 -1 treecombobox.cpp
D treecombobox.h
A treecombobox_p.h treecombobox.h#708686 [License: LGPL (v2)]
M +0 -12 util.h
--- trunk/KDE/kdelibs/kdeprint/driver.cpp #708755:708756
@@ -18,7 +18,7 @@
**/
#include "driver.h"
-#include "driveritem.h"
+#include "driveritem_p.h"
#include <QtCore/QFile>
#include <QtCore/QStringList>
--- trunk/KDE/kdelibs/kdeprint/driveritem.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "driveritem.h"
+#include "driveritem_p.h"
#include "driver.h"
#include <QtGui/QPainter>
--- trunk/KDE/kdelibs/kdeprint/driverview.cpp #708755:708756
@@ -18,8 +18,8 @@
**/
#include "driverview.h"
-#include "droptionview.h"
-#include "driveritem.h"
+#include "droptionview_p.h"
+#include "driveritem_p.h"
#include "driver.h"
#include <QtGui/QHeaderView>
--- trunk/KDE/kdelibs/kdeprint/droptionview.cpp #708755:708756
@@ -17,9 +17,9 @@
* Boston, MA 02110-1301, USA.
**/
-#include "droptionview.h"
+#include "droptionview_p.h"
#include "driver.h"
-#include "driveritem.h"
+#include "driveritem_p.h"
#include <math.h>
#include <QtGui/QLineEdit>
--- trunk/KDE/kdelibs/kdeprint/kfilelist.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kfilelist.h"
+#include "kfilelist_p.h"
#include <QtGui/QToolButton>
#include <QtGui/QLabel>
--- trunk/KDE/kdelibs/kdeprint/kmjobmanager.cpp #708755:708756
@@ -19,7 +19,7 @@
#include "kmjobmanager.h"
#include "kmjob.h"
-#include "kmthreadjob.h"
+#include "kmthreadjob_p.h"
#include "kmfactory.h"
#include <kdebug.h>
--- trunk/KDE/kdelibs/kdeprint/kmmanager.cpp #708755:708756
@@ -22,8 +22,8 @@
#include "kmdbentry.h"
#include "kmfactory.h"
#include "kmvirtualmanager.h"
-#include "kmspecialmanager.h"
-#include "printerfilter.h"
+#include "kmspecialmanager_p.h"
+#include "printerfilter_p.h"
#include "kprinter.h"
#include <QtGui/QActionGroup>
--- trunk/KDE/kdelibs/kdeprint/kmspecialmanager.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kmspecialmanager.h"
+#include "kmspecialmanager_p.h"
#include "kmmanager.h"
#include "kmprinter.h"
#include "kdeprintcheck.h"
--- trunk/KDE/kdelibs/kdeprint/kmthreadjob.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kmthreadjob.h"
+#include "kmthreadjob_p.h"
#include "kmjob.h"
#include "kmjobmanager.h"
--- trunk/KDE/kdelibs/kdeprint/kmuimanager.cpp #708755:708756
@@ -27,12 +27,12 @@
#include "kmmanager.h"
#include "kmprinter.h"
#include "kpdriverpage.h"
-#include "kpmarginpage.h"
+#include "kpmarginpage_p.h"
#include "kpqtpage.h"
-#include "kpfilterpage.h"
-#include "kpfileselectpage.h"
+#include "kpfilterpage_p.h"
+#include "kpfileselectpage_p.h"
#include "kxmlcommand.h"
-#include "kpposterpage.h"
+#include "kpposterpage_p.h"
#include <config.h>
--- trunk/KDE/kdelibs/kdeprint/kpfileselectpage.cpp #708755:708756
@@ -17,8 +17,8 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kpfileselectpage.h"
-#include "kfilelist.h"
+#include "kpfileselectpage_p.h"
+#include "kfilelist_p.h"
#include <QtGui/QLayout>
#include <QtCore/QStringList>
--- trunk/KDE/kdelibs/kdeprint/kpfilterpage.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kpfilterpage.h"
+#include "kpfilterpage_p.h"
#include "kmfactory.h"
#include "kxmlcommand.h"
--- trunk/KDE/kdelibs/kdeprint/kpmarginpage.cpp #708755:708756
@@ -18,7 +18,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kpmarginpage.h"
+#include "kpmarginpage_p.h"
#include "kprinter.h"
#include "driver.h"
#include "marginwidget.h"
--- trunk/KDE/kdelibs/kdeprint/kpposterpage.cpp #708755:708756
@@ -17,8 +17,8 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kpposterpage.h"
-#include "posterpreview.h"
+#include "kpposterpage_p.h"
+#include "posterpreview_p.h"
#include "kprinter.h"
#include "kmfactory.h"
#include "util.h"
--- trunk/KDE/kdelibs/kdeprint/kprintdialog.cpp #708755:708756
@@ -34,7 +34,7 @@
#include "kprinterpropertydialog.h"
#include "plugincombobox.h"
#include "kpcopiespage.h"
-#include "treecombobox.h"
+#include "treecombobox_p.h"
#include "messagewindow.h"
#include <QtGui/QGroupBox>
--- trunk/KDE/kdelibs/kdeprint/kprinter.cpp #708755:708756
@@ -21,7 +21,7 @@
#include "kprinter.h"
#include "kprinterimpl.h"
#include "kprintdialog.h"
-#include "kprintpreview.h"
+#include "kprintpreview_p.h"
#include "kmfactory.h"
#include "kmuimanager.h"
#include "kmmanager.h"
--- trunk/KDE/kdelibs/kdeprint/kprinterimpl.cpp #708755:708756
@@ -24,8 +24,8 @@
#include "kmmanager.h"
#include "kmuimanager.h"
#include "kxmlcommand.h"
-#include "kmspecialmanager.h"
-#include "kmthreadjob.h"
+#include "kmspecialmanager_p.h"
+#include "kmthreadjob_p.h"
#include "kmprinter.h"
#include "driver.h"
--- trunk/KDE/kdelibs/kdeprint/kprintpreview.cpp #708755:708756
@@ -18,7 +18,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "kprintpreview.h"
+#include "kprintpreview_p.h"
#include "kmfactory.h"
#include <QtCore/QFile>
--- trunk/KDE/kdelibs/kdeprint/marginpreview.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "marginpreview.h"
+#include "marginpreview_p.h"
#include <klocale.h>
#include <kdebug.h>
--- trunk/KDE/kdelibs/kdeprint/marginvaluewidget.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "marginvaluewidget.h"
+#include "marginvaluewidget_p.h"
#include <math.h>
#include <kglobal.h>
--- trunk/KDE/kdelibs/kdeprint/marginwidget.cpp #708755:708756
@@ -18,8 +18,8 @@
**/
#include "marginwidget.h"
-#include "marginpreview.h"
-#include "marginvaluewidget.h"
+#include "marginpreview_p.h"
+#include "marginvaluewidget_p.h"
#include "kprinter.h"
#include <QtGui/QComboBox>
--- trunk/KDE/kdelibs/kdeprint/posterpreview.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "posterpreview.h"
+#include "posterpreview_p.h"
#include <kdebug.h>
#include <kprocess.h>
--- trunk/KDE/kdelibs/kdeprint/printerfilter.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "printerfilter.h"
+#include "printerfilter_p.h"
#include "kmprinter.h"
#include "kmfactory.h"
--- trunk/KDE/kdelibs/kdeprint/treecombobox.cpp #708755:708756
@@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA.
**/
-#include "treecombobox.h"
+#include "treecombobox_p.h"
#include <QtGui/QHeaderView>
#include <QtGui/QStandardItem>
--- trunk/KDE/kdelibs/kdeprint/util.h #708755:708756
@@ -25,14 +25,8 @@
#include <kurl.h>
#include <klocale.h>
-#ifdef __GNUC__
-#warning remove function from global namespace
-#endif
KUrl smbToUrl(const QString& work, const QString& server, const QString& printer);
-#ifdef __GNUC__
-#warning remove function from global namespace
-#endif
void urlToSmb(const KUrl& url, QString& work, QString& server, QString& printer);
// those 2 are only workarounds when the login/password may contain
@@ -40,14 +34,8 @@
// as other SMB tools (smbspool) doesn't seem to support encoding. This
// utilities allow to continue working KUrl class (and encoding) within
// KDEPrint, but without encoding outside KDEPrint (shoudl fix bug #38733)
-#ifdef __GNUC__
-#warning remove function from global namespace
-#endif
KUrl smbToUrl(const QString& s);
-#ifdef __GNUC__
-#warning remove function from global namespace
-#endif
QString urlToSmb(const KUrl& url);
#ifdef __GNUC__
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic