[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/amarok/src/context
From:       Maximilian Kossick <maximilian.kossick () googlemail ! com>
Date:       2007-08-31 19:49:58
Message-ID: 1188589798.006113.21011.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 707025 by mkossick:

an observer can only attach to a subject once, so use a qset instead of a qlist


 M  +3 -4      ContextObserver.cpp  
 M  +2 -2      ContextObserver.h  


--- trunk/extragear/multimedia/amarok/src/context/ContextObserver.cpp #707024:707025
@@ -48,14 +48,13 @@
 
 void ContextSubject::attach( ContextObserver *obs )
 {
-    if( !obs || m_observers.indexOf( obs ) != -1 )
+    if( !obs  )
         return;
-    m_observers.append( obs );
+    m_observers.insert( obs );
 }
 
 void ContextSubject::detach( ContextObserver *obs )
 {
-    int index = m_observers.indexOf( obs );
-    if( index != -1 ) m_observers.removeAt( index );
+    m_observers.removeAll( obs );
 }
 
--- trunk/extragear/multimedia/amarok/src/context/ContextObserver.h #707024:707025
@@ -17,7 +17,7 @@
 #include "amarok_export.h"
 #include "Context.h"
 
-#include <QList>
+#include <QSet>
 
 
 class ContextSubject;
@@ -48,7 +48,7 @@
     void messageNotify( const Context::ContextState& message );
     
 private:
-    QList< ContextObserver* > m_observers;
+    QSet<ContextObserver*> m_observers;
 };
 
 #endif
[prev in list] [next in list] [prev in thread] [next in thread]