[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdenetwork/kppp
From:       Arto Hytönen <amthpublic () gmail ! com>
Date:       2007-08-25 19:55:15
Message-ID: 1188071715.308510.14437.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 704683 by amth:

make some of the function args ref-to-const


 M  +1 -1      accounting.cpp  
 M  +1 -1      accounting.h  
 M  +1 -1      conwindow.cpp  
 M  +1 -1      conwindow.h  
 M  +1 -1      modeminfo.cpp  
 M  +1 -1      modeminfo.h  
 M  +2 -2      ruleset.cpp  
 M  +2 -2      ruleset.h  


--- trunk/KDE/kdenetwork/kppp/accounting.cpp #704682:704683
@@ -124,7 +124,7 @@
 }
 
 
-void AccountingBase::logMessage(QString s, bool newline) {
+void AccountingBase::logMessage(const QString &s, bool newline) {
   int old_umask = umask(0077);
 
   QFile f(LogFileName);
--- trunk/KDE/kdenetwork/kppp/accounting.h #704682:704683
@@ -59,7 +59,7 @@
   void changed(QString total, QString session);
 
 protected:
-  void logMessage(QString, bool = false);
+  void logMessage(const QString &, bool = false);
   bool saveCosts();
   bool loadCosts();
 
--- trunk/KDE/kdenetwork/kppp/conwindow.cpp #704682:704683
@@ -341,7 +341,7 @@
 }
 
 
-void ConWindow::slotAccounting(QString total, QString session) {
+void ConWindow::slotAccounting(const QString &total, const QString &session) {
   total_bill->setText(total);
   session_bill->setText(session);
 }
--- trunk/KDE/kdenetwork/kppp/conwindow.h #704682:704683
@@ -61,7 +61,7 @@
   void accounting(bool); // show/ hide accounting info
 
 public slots:
-  void slotAccounting(QString, QString);
+  void slotAccounting(const QString &, const QString &);
 
 private:
   QLabel *info1;
--- trunk/KDE/kdenetwork/kppp/modeminfo.cpp #704682:704683
@@ -303,7 +303,7 @@
 }
 
 
-void ModemInfo::setAtiString(int i, QString s) {
+void ModemInfo::setAtiString(int i, const QString &s) {
   if(i < NUM_OF_ATI)
     ati_label_result[i]->setText(s);
 }
--- trunk/KDE/kdenetwork/kppp/modeminfo.h #704682:704683
@@ -78,7 +78,7 @@
   explicit ModemInfo(QWidget *parent=0, const char *name=0);
 
 public:
-  void setAtiString(int num, QString s);
+  void setAtiString(int num, const QString &s);
 
 private:
   QLabel *ati_label[NUM_OF_ATI];
--- trunk/KDE/kdenetwork/kppp/ruleset.cpp #704682:704683
@@ -421,13 +421,13 @@
   return false;
 }
 
-void RuleSet::setStartTime(QDateTime dt){
+void RuleSet::setStartTime(const QDateTime &dt){
 
   starttime = dt;
 
 }
 
-void RuleSet::getActiveRule(QDateTime dt, double connect_time, double &costs, double &len) {
+void RuleSet::getActiveRule(const QDateTime &dt, double connect_time, double &costs, double &len) {
   // use default costs first
   costs = default_costs;
   len = default_len;
--- trunk/KDE/kdenetwork/kppp/ruleset.h #704682:704683
@@ -76,7 +76,7 @@
   QString currencyString(double val) const;
 
   /// sets the start time -- must be called when the connection has bee established
-  void setStartTime(QDateTime dt);
+  void setStartTime(const QDateTime &dt);
 
   /// returns the "per-connection" costs
   double perConnectionCosts() const;
@@ -87,7 +87,7 @@
   double minimumCosts() const;
 
   /// returns the currently valid rule settings
-  void getActiveRule(QDateTime dt, double connect_time, double &costs, double &len);
+  void getActiveRule(const QDateTime &dt, double connect_time, double &costs, double &len);
 
   /// checks if a rulefile is ok (no parse errors...)
   static int checkRuleFile(const QString &);
[prev in list] [next in list] [prev in thread] [next in thread]