[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kolourpaint (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2007-08-22 8:31:14
Message-ID: 1187771474.103929.14003.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 703227 by dang:

SVN_SILENT Update comments and TODO


 M  +5 -8      commands/tools/selection/kpToolSelectionMoveCommand.cpp  
 M  +8 -2      views/kpView_Paint.cpp  


--- trunk/KDE/kdegraphics/kolourpaint/commands/tools/selection/kpToolSelectionMoveCommand.cpp \
#703226:703227 @@ -103,8 +103,7 @@
     Q_ASSERT (doc);
 
     kpAbstractSelection *sel = doc->selection ();
-    // Have to have pulled pixmap by now.
-    // TODO: Not true for text selections.
+    // Must have content before it can be moved.
     Q_ASSERT (sel && sel->hasContent ());
 
     kpViewManager *vm = viewManager ();
@@ -136,8 +135,7 @@
     Q_ASSERT (doc);
 
     kpAbstractSelection *sel = doc->selection ();
-    // Have to have pulled pixmap by now.
-    // TODO: Not true for text selections.
+    // Must have content before it can be un-moved.
     Q_ASSERT (sel && sel->hasContent ());
 
     kpViewManager *vm = viewManager ();
@@ -172,8 +170,7 @@
         Q_ASSERT (doc);
 
         kpAbstractSelection *sel = doc->selection ();
-        // Have to have pulled pixmap by now.
-        // TODO: Not true for text selections.
+        // Must have content before it can be moved.
         Q_ASSERT (sel && sel->hasContent ());
 
         if (point == sel->topLeft ())
@@ -202,8 +199,8 @@
     Q_ASSERT (doc);
 
     kpAbstractSelection *sel = doc->selection ();
-    // Have to have pulled pixmap by now.
-    // TODO: Not true for text selections.
+    // Must have content before we allow it be stamped onto the document,
+    // to be consistent with the requirement on other selection operations.
     Q_ASSERT (sel && sel->hasContent ());
 
     if (m_oldDocumentImage.isNull ())
--- trunk/KDE/kdegraphics/kolourpaint/views/kpView_Paint.cpp #703226:703227
@@ -248,13 +248,19 @@
     // Draw text cursor
     //
 
+    // TODO: It would be nice to display the text cursor even if it's not
+    //       within the text box (this can happen if the text box is too
+    //       small for the text it contains).
+    //
+    //       However, too much selection repaint code assumes that it
+    //       only paints inside its kpAbstractSelection::boundingRect().
     kpTextSelection *textSel = dynamic_cast <kpTextSelection *> (sel);
     if (textSel &&
         vm->textCursorEnabled () &&
         (vm->textCursorBlinkState () ||
         // For the current main window:
-        // As long as _any_ view has focus, blink _all_ views not just the
-        // one with focus   // !this->isActiveWindow ()
+        //     As long as _any_ view has focus, blink _all_ views not just the
+        //     one with focus.
         !vm->hasAViewWithFocus ()))  // sync: call will break when vm is not held by \
1 mainWindow  {
         QRect rect = vm->textCursorRect ();


[prev in list] [next in list] [prev in thread] [next in thread]