[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/network/ktorrent/plugins/search [POSSIBLY UNSAFE]
From:       Dirk Mueller <mueller () kde ! org>
Date:       2007-08-21 8:23:40
Message-ID: 1187684620.760099.9463.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 702828 by mueller:

just when you think that the world is a better place..
fix shell insertion, once again


 M  +3 -1      searchplugin.cpp   [POSSIBLY UNSAFE: KRun::runCommand]


--- trunk/extragear/network/ktorrent/plugins/search/searchplugin.cpp #702827:702828
@@ -26,6 +26,7 @@
 #include <kstandarddirs.h>
 #include <krun.h>
 #include <kmenu.h>
+#include <kshell.h>
 #include <interfaces/guiinterface.h>
 #include <interfaces/coreinterface.h>
 #include <interfaces/functions.h>
@@ -110,7 +111,8 @@
 			if(SearchPluginSettings::useDefaultBrowser())
 				KRun::runUrl(url,"text/html",0);
 			else
-				KRun::runCommand(QString("%1 \
\"%2\"").arg(SearchPluginSettings::customBrowser()).arg(url.url()),0); \
+				KRun::runCommand(QString("%1 %2") +                                        \
.arg(SearchPluginSettings::customBrowser()).arg(KShell::quoteArg(url.url())),0);  
 			return;
 		}


[prev in list] [next in list] [prev in thread] [next in thread]