[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeutils/kdf
From:       Henrique Pinto <tawhaki () gmail ! com>
Date:       2007-08-12 3:02:29
Message-ID: 1186887749.232153.304.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 699127 by henrique:

 * Fix some krazy issues (marked some constructors as explicit, mostly)


 M  +2 -2      disks.cpp  
 M  +2 -2      disks.h  
 M  +1 -1      kcmdf.h  
 M  +1 -1      kdfwidget.cpp  
 M  +1 -1      kdfwidget.h  
 M  +1 -1      kwikdisk.cpp  
 M  +2 -2      listview.h  
 M  +1 -1      mntconfig.h  
 M  +1 -1      optiondialog.h  


--- trunk/KDE/kdeutils/kdf/disks.cpp #699126:699127
@@ -270,11 +270,11 @@
  QString relPath = inf.fileName();
  if ( inf.isSymLink() ) {
   QString link = inf.readLink();
-  if ( link.startsWith( "/" ) )
+  if ( link.startsWith( '/' ) )
     return link;
   relPath = link;
  }
- return dir.canonicalPath() + "/" + relPath;
+ return dir.canonicalPath() + '/' + relPath;
 }
 
 void DiskEntry::setMountPoint(const QString & mountPoint)
--- trunk/KDE/kdeutils/kdf/disks.h #699126:699127
@@ -40,8 +40,8 @@
 {
   Q_OBJECT
 public:
-  DiskEntry(QObject *parent=0, const char *name=0);
-  DiskEntry(const QString & deviceName, QObject *parent=0, const char *name=0);
+  explicit DiskEntry(QObject *parent=0, const char *name=0);
+  explicit DiskEntry(const QString & deviceName, QObject *parent=0, const char *name=0);
   ~DiskEntry();
   QString lastSysError() {return sysStringErrOut; }
   QString deviceName() const { return device; }
--- trunk/KDE/kdeutils/kdf/kcmdf.h #699126:699127
@@ -35,7 +35,7 @@
   Q_OBJECT
   
   public:
-    KDiskFreeWidget( const KComponentData &inst, QWidget *parent = 0  );
+    explicit KDiskFreeWidget( const KComponentData &inst, QWidget *parent = 0  );
     ~KDiskFreeWidget();
 
     QString quickHelp() const;
--- trunk/KDE/kdeutils/kdf/kdfwidget.cpp #699126:699127
@@ -514,7 +514,7 @@
       }
       else
       {
-	cmd += " " + KShell::quoteArg(disk->mountPoint()) +" &";
+	cmd += ' ' + KShell::quoteArg(disk->mountPoint()) + " &";
       }
       system( QFile::encodeName(cmd) );
     }
--- trunk/KDE/kdeutils/kdf/kdfwidget.h #699126:699127
@@ -111,7 +111,7 @@
     };
 
   public:
-    KDFWidget( QWidget *parent=0, bool init=false);
+    explicit KDFWidget( QWidget *parent=0, bool init=false);
     ~KDFWidget( );
 
   public slots:
--- trunk/KDE/kdeutils/kdf/kwikdisk.cpp #699126:699127
@@ -256,7 +256,7 @@
          }
          else
          {
-            cmd += " " + KShell::quoteArg(disk->mountPoint()) +" &";
+            cmd += ' ' + KShell::quoteArg(disk->mountPoint()) +" &";
          }
          system( QFile::encodeName(cmd) );
       }
--- trunk/KDE/kdeutils/kdf/listview.h #699126:699127
@@ -30,8 +30,8 @@
   Q_OBJECT
 
   public:
-    CListView( QWidget *parent=0, const char *name=0, int visibleItem=10 );
-    
+    explicit CListView( QWidget *parent=0, const char *name=0, int visibleItem=10 );
+
     void setVisibleItem( int visibleItem, bool updateSize=true );
     virtual QSize sizeHint( void ) const; 
     const QPixmap &icon( const QString &iconName, bool drawBorder );
--- trunk/KDE/kdeutils/kdf/mntconfig.h #699126:699127
@@ -60,7 +60,7 @@
     };
 
   public:
-    MntConfigWidget( QWidget *parent=0, bool init=false );
+    explicit MntConfigWidget( QWidget *parent=0, bool init=false );
     ~MntConfigWidget();
 
   public slots:
--- trunk/KDE/kdeutils/kdf/optiondialog.h #699126:699127
@@ -30,7 +30,7 @@
   Q_OBJECT
 
   public:
-    COptionDialog( QWidget *parent=0, const char *name=0, bool modal=true );
+    explicit COptionDialog( QWidget *parent=0, const char *name=0, bool modal=true );
     ~COptionDialog( void );
 
   protected slots:
[prev in list] [next in list] [prev in thread] [next in thread]