[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase
From:       David Faure <faure () kde ! org>
Date:       2007-08-01 9:43:23
Message-ID: 200708011143.23444.faure () kde ! org
[Download RAW message or body]

On Thursday 26 July 2007, Thiago Macieira wrote:
> --- trunk/KDE/kdebase/apps/lib/konq/konq_undo.cc #693037:693038
> @@ -357,7 +357,7 @@
>      d->m_undoJob = 0;
>  
>      if ( d->m_currentJob )
> -        d->m_currentJob->doKill();
> +        d->m_currentJob->kill();
>  
>      d->m_currentJob = 0;
>  

I think the reason was to avoid signals being sent; shouldn't this be a kill(Quietly)?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]