[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kio/kio
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-08-01 3:45:25
Message-ID: 200708010045.25777.thiago () kde ! org
[Download RAW message or body]


Thiago Macieira wrote:
>Rafał Rzepecki wrote:
>>SVN commit 694826 by divide:
>>
>>Added a missing constructor.
>
>It wasn't missing. I had intentionally not added it.

I've been told that some compilers don't like the fact that this class 
could never be constructed. They report a compilation error on that.

For that, I thank you for adding this.

Even though I think it's none of the compiler's business to make it an 
error. Yes, it can't be constructed: that's why it's NOT constructed. It 
should be a warning at most.

>
>>--- trunk/KDE/kdelibs/kio/kio/job.cpp #694825:694826
>>@@ -2687,6 +2687,11 @@
>>
>> class KIO::SpecialJobPrivate: public TransferJobPrivate
>> {
>>+    SpecialJobPrivate(const KUrl& url, int command,
>>+                             const QByteArray &packedArgs,
>>+                             const QByteArray &_staticData)
>>+        : TransferJobPrivate(url, command, packedArgs, _staticData)
>>+    {}
>> };
>>
>> SpecialJob::SpecialJob(const KUrl &url, const QByteArray &packedArgs)


-- 
   Thiago Macieira   -   thiago (AT) macieira.info - thiago (AT) kde.org
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C   966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]