[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/libkleo/backends/qgpgme
From:       Marc Mutz <mutz () kde ! org>
Date:       2007-07-27 17:20:51
Message-ID: 200707271919.41239.mutz () kde ! org
[Download RAW message or body]

On Friday 27 July 2007 16:22, Thiago Macieira wrote:
> Marc Mutz wrote:
> >Fix yet another two bugs introduced this morning (merged channels
> > instead of stdout only, and missing \r\n removal (K3ProcIO did that for
> > us, QProcess doesn't)), and ported the seond occurrence of K3ProcIO to
> > KProcess. A bit of cleanup, too.
>
> QProcess does translate \r\n if you give it the QIODevice::Text flag when
> opening.

Thanks, but that's not what was missing. KProcIO::readLn() (old code) doesn't 
return the \n that ends the line, while {Q,K}Process::readLine() (new code) 
does -> porting gocha. That's what I fixed.
[prev in list] [next in list] [prev in thread] [next in thread]