[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore/jobs
From:       Thomas McGuire <thomas.mcguire () gmx ! net>
Date:       2007-07-24 12:12:14
Message-ID: 200707241412.14603.thomas.mcguire () gmx ! net
[Download RAW message or body]

On Monday 12 March 2007, Kevin Ottens wrote:
> SVN commit 641910 by ervin:
>
> Make the progress related signals private. We don't want jobs too emit
> them directly. They should use the setters and emitResult instead.
>
>
>  M  +8 -0      kjob.h
>
>
> --- trunk/KDE/kdelibs/kdecore/jobs/kjob.h #641909:641910
> @@ -285,6 +285,9 @@
>      unsigned long percent() const;
>
>  Q_SIGNALS:
> +#ifndef Q_MOC_RUN
> +private: // don't tell moc, but those signals are in fact private
> +#endif
>      /**
>       * Emitted when the job is finished, in any case. It is used to notify
>       * observers that the job is terminated and that progress can be
> hidden. @@ -319,6 +322,7 @@
>       */
>      void result( KJob *job );
>
> +Q_SIGNALS:
>      /**
>       * Emitted to display general description of this job. A description
> has * a title and two optional fields which can be used to complete the @@
> -356,6 +360,10 @@
>      void warning( KJob *job, const QString &plain, const QString &rich =
> QString() );
>
>
> +Q_SIGNALS:
> +#ifndef Q_MOC_RUN
> +private: // don't tell moc, but those signals are in fact private
> +#endif
>      /**
>       * Emitted when we know the amount the job will have to process. The
> unit of this * amount is sent too. It can be emitted several times if the
> job manages several
This breaks APIDOX generation. Have a look at 
http://api.kde.org/4.0-api/kdelibs-apidocs/kdecore/html/classKJob.html .
Things like the result signal are missing here, even though the example on 
that page shows that it should be used.

[prev in list] [next in list] [prev in thread] [next in thread]