[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdecore/config
From:       Peter Kümmel <syntheticpp () yahoo ! com>
Date:       2007-07-22 11:30:41
Message-ID: 1185103841.178407.15985.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 690851 by kuemmel:

fix kbuildsycoca4 crash on windows: QFileInfo uses X_OK in isExecutable on Linux but \
not on Windows. TODO replace remaining ::access function calls

 M  +2 -2      kdesktopfile.cpp  


--- trunk/KDE/kdelibs/kdecore/config/kdesktopfile.cpp #690850:690851
@@ -271,7 +271,7 @@
 
   if (!te.isEmpty()) {
     if (!QDir::isRelativePath(te)) {
-      if (::access(QFile::encodeName(te), X_OK))
+      if (QFileInfo(te).isExecutable())
 	return false;
     } else {
       // !!! Sergey A. Sukiyazov <corwin@micom.don.ru> !!!
@@ -283,7 +283,7 @@
       bool match = false;
       for (; it != dirs.end(); ++it) {
 	QString fName = *it + '/' + te;
-	if (::access(QFile::encodeName(fName), X_OK) == 0)
+	if (QFileInfo(fName).isExecutable())
 	{
 	  match = true;
 	  break;


[prev in list] [next in list] [prev in thread] [next in thread]