[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kolourpaint (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2007-07-14 3:09:57
Message-ID: 1184382597.961985.17096.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 687618 by dang:

SVN_SILENT comments

 M  +9 -1      kpdocument.cpp  


--- branches/KDE/3.5/kdegraphics/kolourpaint/kpdocument.cpp #687617:687618
@@ -1141,6 +1141,10 @@
         if (m_selection->pixmap ())
             slotContentsChanged (m_selection->boundingRect ());
         else
+            // TODO: Should emit contentsChanged() instead?
+            //       I don't think it matters since contentsChanged() is
+            //       connected to updateViews() anyway (see
+            //       kpMainWindow::setDocument ()).
             vm->updateViews (m_selection->boundingRect ());
 
         delete m_selection;
@@ -1188,9 +1192,13 @@
     if (m_selection->pixmap ())
         slotContentsChanged (m_selection->boundingRect ());
     else
+        // TODO: Should emit contentsChanged() instead?
+        //       I don't think it matters since contentsChanged() is
+        //       connected to updateViews() anyway (see
+        //       kpMainWindow::setDocument ()).
         vm->updateViews (m_selection->boundingRect ());
 
-    // There's no need to disconnect() since we:
+    // There's no need to disconnect() the old selection since we:
     //
     // 1. Connect our _copy_ of the given selection.
     // 2. We delete our copy when setSelection() is called again.
[prev in list] [next in list] [prev in thread] [next in thread]