[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kolourpaint
From:       Clarence Dang <dang () kde ! org>
Date:       2007-07-12 5:48:21
Message-ID: 1184219301.421645.615.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 686784 by dang:

+explanation

[BACKPORT FROM branches/work/~dang/kdegraphics/kolourpaint]


 M  +7 -0      kpdocument.cpp  


--- branches/KDE/3.5/kdegraphics/kolourpaint/kpdocument.cpp #686783:686784
@@ -1142,6 +1142,7 @@
             slotContentsChanged (m_selection->boundingRect ());
         else
             vm->updateViews (m_selection->boundingRect ());
+
         delete m_selection;
     }
 
@@ -1189,6 +1190,12 @@
     else
         vm->updateViews (m_selection->boundingRect ());
 
+    // There's no need to disconnect() since we:
+    //
+    // 1. Connect our _copy_ of the given selection.
+    // 2. We delete our copy when setSelection() is called again.
+    //
+    // See code above for both.
     connect (m_selection, SIGNAL (changed (const QRect &)),
              this, SLOT (slotContentsChanged (const QRect &)));
 
[prev in list] [next in list] [prev in thread] [next in thread]