[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kspread/plugins/scripting
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2007-07-08 1:52:53
Message-ID: 1183859573.677397.19800.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 685050 by sebsauer:

pass the QRect's rather then the names

 M  +6 -2      ScriptingListener.cpp  
 M  +3 -2      ScriptingListener.h  
 M  +1 -1      scripts/logger.py  


--- trunk/koffice/kspread/plugins/scripting/ScriptingListener.cpp #685049:685050
@@ -55,10 +55,14 @@
 
 void ScriptingCellListener::slotChanged(const Region& region)
 {
-    emit regionChanged( region.name(d->sheet).split(";") );
     Region::ConstIterator end(region.constEnd());
+
+    QVariantList ranges;
     for (Region::ConstIterator it = region.constBegin(); it != end; ++it)
-    {
+        ranges << (*it)->rect();
+    emit regionChanged(ranges);
+
+    for (Region::ConstIterator it = region.constBegin(); it != end; ++it) {
         const QRect r( (*it)->rect() );
         for (int row = r.top(); row <= r.bottom(); ++row)
             for (int col = r.left(); col <= r.right(); ++col)
--- trunk/koffice/kspread/plugins/scripting/ScriptingListener.h #685049:685050
@@ -22,6 +22,7 @@
 #define SCRIPTINGLISTENER_H
 
 #include <QRect>
+#include <QVariant>
 #include <QObject>
 
 namespace KSpread {
@@ -44,7 +45,7 @@
     *     print "regions=%s" % regions
     * def cellChanged(column, row):
     *     print "column=%i row=%i" % (column,row)
-    * listener.connect("regionChanged(QStringList)", regionChanged)
+    * listener.connect("regionChanged(QVariantList)", regionChanged)
     * listener.connect("cellChanged(int,int)", cellChanged)
     * \endcode
     */
@@ -56,7 +57,7 @@
             virtual ~ScriptingCellListener();
 
         Q_SIGNALS:
-            void regionChanged(const QStringList& ranges);
+            void regionChanged(const QVariantList& ranges);
             void cellChanged(int column, int row);
 
         private Q_SLOTS:
--- trunk/koffice/kspread/plugins/scripting/scripts/logger.py #685049:685050
@@ -46,7 +46,7 @@
         if not self.listener:
             raise "Failed to create listener for sheetname '%s' and range '%s'" % (sheetname,cellrange)
         self.addLog( "Start logging sheet='%s' range='%s'" % (sheetname,cellrange) )
-        self.listener.connect("regionChanged(QStringList)", self.regionChanged)
+        self.listener.connect("regionChanged(QVariantList)", self.regionChanged)
         self.listener.connect("cellChanged(int,int)", self.cellChanged)
 
     def regionChanged(self, regions):
[prev in list] [next in list] [prev in thread] [next in thread]