[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/krita/ui
From:       Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date:       2007-07-04 9:50:35
Message-ID: 200707041150.38820.stefan.nikolaus () kdemail ! net
[Download RAW message or body]


On Wednesday 04 July 2007 11:36:12 Thomas Zander wrote:
> On Wednesday 04 July 2007 10:54:03 Cyrille Berger wrote:
> > SVN commit 683125 by berger:
> >
> > make the dialog non modal
> >
> >  M  +1 -0      kis_filter_dialog.cc
> >  M  +13 -6     kis_filter_handler.cc
> >  M  +1 -0      kis_filter_handler.h
>
> Instead of just deleting the dialog, I suggest using the
> QObject::deleteLater() method. I always do that in the dialog's accept()
> method.
>
> It also saves you from having an external pointer to the dialog, which I
> see you have and delete from several places.

One can also use QWidget::setAttribute(Qt::WA_DeleteOnClose);

> One bug I noticed there is that you don't set the variable to zero after
> deletion, which means you may delete it twice.

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]