[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: qt-copy
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2007-06-28 8:36:44
Message-ID: 200706281036.44706.hausmann () kde ! org
[Download RAW message or body]


On Thursday 28 June 2007 10:29:31 Oswald Buddenhagen wrote:
> On Thu, Jun 28, 2007 at 08:09:48AM +0000, Simon Hausmann wrote:
> > QProcess readchannel data corruption patch from Andreas, reported from
> > core-devel
> > as well as by a customer.
>
> guess who it was. :))

I'm not going to disclose the name, but the customer was using Qt on Windows.

But if you separately reported the same issue I'd be interested in the task 
number so we can close it :) (I thought I had it bookmarked, but I can't find 
it anymore :(

> it should be noted that i was unable to convince andreas to accept that
> this is a bug (or, rather, andy was). how did you manage this? :)
>
> > --- trunk/qt-copy/patches/README #681222:681223
> >  void QProcess::setReadChannel(ProcessChannel channel)
> >  {
> >      Q_D(QProcess);
> > +    if (d->processChannel != channel) {
> > +        QByteArray buf = d->buffer.readAll();
> > +        if (d->processChannel == QProcess::StandardOutput) {
> > +            for (int i = buf.size() - 1; i >= 0; --i)
> > +                d->outputReadBuffer.ungetChar(buf.at(i));
> > +        } else {
> > +            for (int i = buf.size() - 1; i >= 0; --i)
> > +                d->errorReadBuffer.ungetChar(buf.at(i));
> > +        }
> > +    }
> >      d->processChannel = channel;
> >  }
>
> not much nicer than the workaround i have in KProcess. :)
> btw, when do you think i should remove it? will kde 4.0 require the
> latest qt 4.3 bugfix release at that time?

I think it makes sense to require the latest 4.3 patch release.

Simon

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]