[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kde3support/kdeui
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2007-06-18 9:41:04
Message-ID: 20070618094104.GD16141 () morpheus ! apaku ! dnsalias ! org
[Download RAW message or body]

On 18.06.07 11:23:03, Oswald Buddenhagen wrote:
> On Sun, Jun 17, 2007 at 09:35:54PM +0000, Andreas Pakulat wrote:
> > --- trunk/KDE/kdelibs/kde3support/kdeui/k3spell.cpp #676887:676888
> > @@ -96,11 +113,11 @@
> > -//  Connects a slot to K3ProcIO's output signal
> > -#define OUTPUT(x) (connect (proc, SIGNAL (readReady(K3ProcIO *)), this, SLOT (x(K3ProcIO *))))
> > +//  Connects a slot to KProcess's output signal
> > +#define OUTPUT(x) (connect (proc, SIGNAL (readyReadStandardOutput()), this, SLOT (x())))
> >
> >  // Disconnect a slot from...
> > -#define NOOUTPUT(x) (disconnect (proc, SIGNAL (readReady(K3ProcIO *)), this, SLOT (x(K3ProcIO *))))
> > +#define NOOUTPUT(x) (disconnect (proc, SIGNAL (readyReadStandardOutput()), this, SLOT (x())))
> >
> IOCCC nomination pending. :)
> fwiw, this slot-switching is very risky. if multiple lines get only one
> notification because of some processing delay, everything will break
> down. this needs a proper state machine in *one* slot.
> yes, i know that this is not your code and that this is a compat class.
> but do we want to keep potentially serious bugs in it?

Well, wasn't this problematic throughout kde3 as well? If so it
seemingly didn't produce enough bugs to get fixed, so why bother now?
After all app-developers are supposed to use sonnet for spell checking
for KDE4 apps. And K3Spell spellchecking crashes applications currently
anyway (also before my change) somewhere in K3SpellDialog or similar
class.

Andreas

-- 
Everything will be just tickety-boo today.
[prev in list] [next in list] [prev in thread] [next in thread]