[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepimlibs/kxmlrpcclient
From:       Frank Osterfeld <frank.osterfeld () kdemail ! net>
Date:       2007-06-17 21:25:24
Message-ID: 1182115524.943484.21283.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 676883 by osterfeld:

API cleanup: setDigestAuthEnabled() instead of enableDigestAuth()/disableDigestAuth()


 M  +8 -18     client.cpp  
 M  +11 -15    client.h  


--- trunk/KDE/kdepimlibs/kxmlrpcclient/client.cpp #676882:676883
@@ -36,13 +36,15 @@
 class Client::Private
 {
   public:
+    Private() : mUserAgent( "KDE XMLRPC resources" ), mDigestAuth( false ) {}
+
+    void queryFinished( Query * );
+
     KUrl mUrl;
     QString mUserAgent;
     bool mDigestAuth;
 
     QList<Query*> mPendingQueries;
-
-    void queryFinished( Query * );
 };
 
 void Client::Private::queryFinished( Query *query )
@@ -54,19 +56,12 @@
 Client::Client( QObject *parent )
   : QObject( parent ), d( new Private )
 {
-  d->mUserAgent = "KDE XMLRPC resources";
-  d->mDigestAuth = false;
 }
 
 Client::Client( const KUrl &url, QObject *parent )
   : QObject( parent ), d( new Private )
 {
-  if ( url.isValid() ) {
-    d->mUrl = url;
-  }
-
-  d->mUserAgent = "KDE XMLRPC resources";
-  d->mDigestAuth = false;
+  d->mUrl = url;
 }
 
 Client::~Client()
@@ -101,21 +96,16 @@
   d->mUserAgent = userAgent;
 }
 
-bool Client::digestAuth() const
+bool Client::isDigestAuthEnabled() const
 {
   return d->mDigestAuth;
 }
 
-void Client::enableDigestAuth()
+void Client::setDigestAuthEnabled( bool enabled )
 {
-  d->mDigestAuth = true;
+  d->mDigestAuth = enabled;
 }
 
-void Client::disableDigestAuth()
-{
-  d->mDigestAuth = false;
-}
-
 void Client::call( const QString &method, const QList<QVariant> &args,
                    QObject *msgObj, const char *messageSlot,
                    QObject *faultObj, const char *faultSlot, const QVariant &id )
--- trunk/KDE/kdepimlibs/kxmlrpcclient/client.h #676882:676883
@@ -24,13 +24,14 @@
 #ifndef KXML_RPC_CLIENT_H
 #define KXML_RPC_CLIENT_H
 
+#include "kxmlrpcclient_export.h"
+
+#include <KUrl>
+
 #include <QtCore/QList>
 #include <QtCore/QObject>
 #include <QtCore/QVariant>
 
-#include <kurl.h>
-#include "kxmlrpcclient_export.h"
-
 /** Names for XmlRpc related classes */
 namespace KXmlRpc {
 
@@ -55,7 +56,7 @@
 
   public:
     /**
-			Constructs a XML-RPC Client.
+      Constructs a XML-RPC Client.
 
       @param parent the parent of this object, defaults to NULL.
      */
@@ -110,24 +111,19 @@
       Returns true if HTTP-Digest authentication is enabled, false
       if not.
 
-      @see enableDigestAuth(), disableDigestAuth()
+      @see setDigestAuthEnabled()
      */
-    bool digestAuth() const;
+    bool isDigestAuthEnabled() const;
 
-    /**
-      Sets HTTP-Digest authentication on.
 
-      @see digestAuth(), disableDigestAuth()
-     */
-    void enableDigestAuth();
-
     /**
-      Sets HTTP-Digest authentication off.
+      Enables/disables HTTP-Digest authentication
 
-      @see enableDigestAuth(), digestAuth()
+      @see isDigestAuthEnabled()
      */
-    void disableDigestAuth();
 
+    void setDigestAuthEnabled( bool enabled );
+
   public Q_SLOTS:
     /**
       Calls the given method on a XML-RPC server, with the given
[prev in list] [next in list] [prev in thread] [next in thread]