[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs
From:       Thomas Zander <zander () kde ! org>
Date:       2007-06-02 7:50:34
Message-ID: 200706020950.34834.zander () kde ! org
[Download RAW message or body]


On Saturday 02 June 2007 09:03:30 Thorsten Zachmann wrote:
> SVN commit 670616 by zachmann:
>
> o Added the possibility to do not call repaint when a shape is inserted
>   into the KoShapeManager. Whit this it is possible to only repaint
> e.g. only the active page in one view when it changes.
> o Use the new possibility and only trigger a repaint after all shapes
>   has been set in kopageapp.
>
>
>  M  +8 -6      flake/KoShapeManager.cpp
>  M  +4 -2      flake/KoShapeManager.h
>  M  +2 -2      kopageapp/KoPAView.cpp

I'm not sure I like this solution. It is very specific for one use case 
and just adds a useless bool in a public API for most others.

The idea that you insert a shape (again) is a bit weird to me, so I can't 
propose an alternative here,  but my first instinct says that you should 
have this kind of check in your canvas implementation. It can ignore an 
updateCanvas call outside of the current page area.
-- 
Thomas Zander

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]