[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdesupport/qca/plugins/qca-gnupg/gpgproc
From:       Justin Karneges <infiniti () affinix ! com>
Date:       2007-05-31 22:47:25
Message-ID: 1180651645.700604.6945.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 670286 by infiniti:

better pipe inheritability handling


 M  +63 -53    gpgproc.cpp  
 M  +4 -3      sprocess.cpp  
 M  +1 -1      sprocess.h  


--- trunk/kdesupport/qca/plugins/qca-gnupg/gpgproc/gpgproc.cpp #670285:670286
@@ -104,6 +104,7 @@
 	GPGProc *q;
 	QString bin;
 	QStringList args;
+	GPGProc::Mode mode;
 	SProcess *proc;
 #ifdef QT_PIPE_HACK
 	QProcessSignalRelay *proc_relay;
@@ -246,36 +247,67 @@
 			return false;
 		}
 
-#ifdef Q_OS_WIN
-		if(makeAux && !pipeAux.writeEnd().winDupHandle())
+		return true;
+	}
+
+	void setupArguments()
+	{
+		QStringList fullargs;
+		fullargs += "--no-tty";
+
+		if(mode == ExtendedMode)
 		{
-			closePipes();
-			emit q->debug("Win: Error dup'ing pipeAux");
-			return false;
-		}
+			fullargs += "--enable-special-filenames";
 
-		if(!pipeCommand.writeEnd().winDupHandle())
-		{
-			closePipes();
-			emit q->debug("Win: Error dup'ing pipeCommand");
-			return false;
+			fullargs += "--status-fd";
+			fullargs += QString::number(pipeStatus.writeEnd().idAsInt());
+
+			fullargs += "--command-fd";
+			fullargs += QString::number(pipeCommand.readEnd().idAsInt());
 		}
 
-		if(!pipeStatus.readEnd().winDupHandle())
+		for(int n = 0; n < args.count(); ++n)
 		{
-			closePipes();
-			emit q->debug("Win: Error dup'ing pipeStatus");
-			return false;
+			QString a = args[n];
+			if(mode == ExtendedMode && a == "-&?")
+				fullargs += QString("-&") + QString::number(pipeAux.readEnd().idAsInt());
+			else
+				fullargs += a;
 		}
-#endif
 
-		return true;
+		QString fullcmd = fullargs.join(" ");
+		emit q->debug(QString("Running: [") + bin + ' ' + fullcmd + ']');
+
+		args = fullargs;
 	}
 
 public slots:
 	void doStart()
 	{
+#ifdef Q_OS_WIN
+		// Note: for unix, inheritability is set in SProcess
+		if(pipeAux.readEnd().isValid())
+			pipeAux.readEnd().setInheritable(true);
+		if(pipeCommand.readEnd().isValid())
+			pipeCommand.readEnd().setInheritable(true);
+		if(pipeStatus.writeEnd().isValid())
+			pipeStatus.writeEnd().setInheritable(true);
+#endif
+
+		setupArguments();
+
 		proc->start(bin, args);
+
+		// FIXME: From reading the source to Qt on both windows
+		//   and unix platforms, we know that fork/CreateProcess
+		//   are called in start.  However this is not guaranteed
+		//   from an API perspective.  We should probably call
+		//   QProcess::waitForStarted() to synchronously ensure
+		//   fork/CreateProcess are called before closing these
+		//   pipes.
+		pipeAux.readEnd().close();
+		pipeCommand.readEnd().close();
+		pipeStatus.writeEnd().close();
 	}
 
 	void aux_written(int x)
@@ -323,10 +355,12 @@
 	{
 		emit q->debug("Process started");
 
+		// Note: we don't close these here anymore.  instead we
+		//   do it just after calling proc->start().
 		// close these, we don't need them
-		pipeAux.readEnd().close();
+		/*pipeAux.readEnd().close();
 		pipeCommand.readEnd().close();
-		pipeStatus.writeEnd().close();
+		pipeStatus.writeEnd().close();*/
 
 		// do the pre* stuff
 		if(!pre_stdin.isEmpty())
@@ -547,8 +581,6 @@
 
 void GPGProc::start(const QString &bin, const QStringList &args, Mode mode)
 {
-	int n;
-
 	if(isActive())
 		d->reset(ResetSessionAndData);
 
@@ -563,45 +595,22 @@
 			return;
 		}
 
-		emit debug("Pipe setup complete");
-	}
-
-	QStringList fullargs;
-	fullargs += "--no-tty";
-
-	if(mode == ExtendedMode)
-	{
-		fullargs += "--enable-special-filenames";
-
-		fullargs += "--status-fd";
-		fullargs += d->pipeStatus.writeEnd().idAsString();
-
-		fullargs += "--command-fd";
-		fullargs += d->pipeCommand.readEnd().idAsString();
-
 		d->need_status = true;
-	}
 
-	for(n = 0; n < args.count(); ++n)
-	{
-		QString a = args[n];
-		if(mode == ExtendedMode && a == "-&?")
-			fullargs += (QString("-&") + d->pipeAux.readEnd().idAsString());
-		else
-			fullargs += a;
+		emit debug("Pipe setup complete");
 	}
 
-	QString fullcmd = fullargs.join(" ");
-	emit debug(QString("Running: [") + bin + ' ' + fullcmd + ']');
-
 	d->proc = new SProcess(d);
 
 #ifdef Q_OS_UNIX
 	QList<int> plist;
-	plist += d->pipeAux.writeEnd().id();
-	plist += d->pipeCommand.writeEnd().id();
-	plist += d->pipeStatus.readEnd().id();
-	d->proc->setClosePipeList(plist);
+	if(d->pipeAux.readEnd().isValid())
+		plist += d->pipeAux.readEnd().id();
+	if(d->pipeCommand.readEnd().isValid())
+		plist += d->pipeCommand.readEnd().id();
+	if(d->pipeStatus.writeEnd().isValid())
+		plist += d->pipeStatus.writeEnd().id();
+	d->proc->setInheritPipeList(plist);
 #endif
 
 	// enable the pipes we want
@@ -630,7 +639,8 @@
 #endif
 
 	d->bin = bin;
-	d->args = fullargs;
+	d->args = args;
+	d->mode = mode;
 	d->startTrigger.start();
 }
 
--- trunk/kdesupport/qca/plugins/qca-gnupg/gpgproc/sprocess.cpp #670285:670286
@@ -21,6 +21,7 @@
 
 #ifdef Q_OS_UNIX
 # include <unistd.h>
+# include <fcntl.h>
 #endif
 
 namespace gpgQCAPlugin {
@@ -38,16 +39,16 @@
 }
 
 #ifdef Q_OS_UNIX
-void SProcess::setClosePipeList(const QList<int> &list)
+void SProcess::setInheritPipeList(const QList<int> &list)
 {
 	pipeList = list;
 }
 
 void SProcess::setupChildProcess()
 {
-	// close all pipes
+	// set the pipes to be inheritable
 	for(int n = 0; n < pipeList.count(); ++n)
-		::close(pipeList[n]);
+		::fcntl(pipeList[n], F_SETFD, (::fcntl(pipeList[n], F_GETFD) & ~FD_CLOEXEC));
 }
 #endif
 
--- trunk/kdesupport/qca/plugins/qca-gnupg/gpgproc/sprocess.h #670285:670286
@@ -33,7 +33,7 @@
 	~SProcess();
 
 #ifdef Q_OS_UNIX
-	void setClosePipeList(const QList<int> &);
+	void setInheritPipeList(const QList<int> &);
 
 protected:
 	virtual void setupChildProcess();
[prev in list] [next in list] [prev in thread] [next in thread]