[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevelop/lib
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2007-05-25 20:02:46
Message-ID: 200705252202.50798.hausmann () kde ! org
[Download RAW message or body]


On Friday 25 May 2007 21:56:10 Andreas Pakulat wrote:
> On 25.05.07 18:58:06, Dukju Ahn wrote:
> > -    void processStdErr( const QString& s )
> > -    {
>
> This is not very nice, unless there's a real reason functions shouldn't
> be moved around. Not a big deal here, just to let you know.
>
> > +        QStringList lineList;
> >          while ( (pos = stdoutbuf.indexOf('\n')) != -1)
>
> I didn't change this during the "refactoring" to a dpointer, but we need
> to also recognize \r\n as we're targetting windows. I guess we should do
> something like stdoutbuf.replace('\r\n','\n') before the loop.

Please don't do this in apps. Let the toolkit to it by opening the QIODevice 
with QIODevice::Text (if this is a QProcess you pass this to 
QProcess::start). That works transparently and gives you always Unix 
linefeeds.

Simon

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]