[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/config
From:       David Faure <faure () kde ! org>
Date:       2007-05-21 15:07:11
Message-ID: 200705211707.12204.faure () kde ! org
[Download RAW message or body]

On Monday 21 May 2007, Andreas Pakulat wrote:
> On 21.05.07 13:20:48, Laurent Montel wrote:
> > SVN commit 666984 by mlaurent:
> > 
> > Revert as into kde3.x
> > (now we can save/load element as previously, if we want
> > to config it redefine usrWriteConfig and usrLoadConfig)
> 
> You forgot to make readConfig,writeConfig,useDefaults and setDefaults
> virtual. Without those being virtual kdevelop breaks.

Can you tell me why readConfig/writeConfig should be virtual? I didn't follow the initial discussions,
but I had a look with Laurent, and: either you call readConfig and then you want the default impl,
or you don't call it if you don't want the default impl ... so why virtual? Any additional behavior can
be done in usrReadConfig/usrWriteConfig.


-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]