[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevelop/lib
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2007-05-19 12:19:00
Message-ID: 20070519121900.GA3267 () morpheus ! apaku ! dnsalias ! org
[Download RAW message or body]

On 19.05.07 08:14:34, Dukju Ahn wrote:
> SVN commit 666233 by dukjuahn:
> 
> Implemented outputview filtering.
> 
> Components who want to hookup special action into outputview item
> or who want to paint their output string with special apprearance(font/color) 
> will now register their own outputview item factory. This factory will
> create customized item for outputview.

A few notes:

- why is there a default implementation? If there's no factory use
  standard items, that way we don't need a library for this stuff
- for types use an enum, not defines and don't use an int return type,
  use the enum type. We're in C++ land so we want proper types.
- what is type() needed for anyway?
- why is there a constructor in IOutputViewItem? It can be a plain
  interface, no need for a constructor, nothing should be allowed to
  create an IOutputViewItem (at the moment).

Andreas

-- 
Many changes of mind and mood; do not hesitate too long.
[prev in list] [next in list] [prev in thread] [next in thread]