[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: qt-copy/patches
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2007-05-16 7:51:16
Message-ID: 200705160951.16915.hausmann () kde ! org
[Download RAW message or body]


On Monday 07 May 2007 18:59:00 Ralf Habacker wrote:
> Simon Hausmann schrieb:
> > On Sunday 06 May 2007 14:28:12 Ralf Habacker wrote:
> >> Simon Hausmann schrieb:
> >>> On Sunday 06 May 2007 12:05:57 Ralf Habacker wrote:
> >>>> SVN commit 661655 by habacker:
> >>>>
> >>>> win32 patches
> >>>>
> >>>>  A             0169-win32-openssldir-any-dir.diff
> >>>
> >>> It looks like this one has been rejected as it is configurable through
> >>> INCLUDE and PATH:
> >>>
> >>> http://www.trolltech.com/developer/task-tracker/index_html?id=157892&me
> >>>th od=entry
> >>
> >> This looks inconsistent to me. openssl needs INCLUDE for include header
> >> and PATH for (import-)libraries. The latter looks very uncommon to me,
> >> better would be to use LIB.
> >
> > Yes, I think it was a typo in the rejected task description, LIB was
> > meant of course instead of PATH.
> >
> >> dbus installation root is detected either by the environment var
> >> <ProgramFiles> and the dbus subdir  or the environment var DBUSDIR if
> >> present see
> >> http://websvn.kde.org/trunk/qt-copy/tools/qdbus/src/src.pro?view=markup.
> >>
> >> which means for dbus is is required either to set
> >> - DBUSDIR for header and libraries  and PATH for dll's/applictions or
> >> - only PATH for dll's/applictions if dbus is installed in the default
> >> location <ProgramFiles>/dbus
> >>
> >> My patch tries to handle openssl in the same manner, in fact it is a
> >> cleanup of external package detection.
> >
> > For now we stay with INCLUDE and LIB for external packages. I've
> > submitted your qdbus-configure patch (without the DBUSDIR bit) and Marius
> > rebuilt configure.exe, so tomorrow's snapshot should work fine.
>
> Will the DBUSDIR settings from tools\qdbus\src\src.pro be also removed ?
> If no the following messages will be printed while configureing
>
>  Reading F:/daten/qt-copy/tools/qdbus/src/src.pro
> Project MESSAGE: DBUSDIR not specified. Using C:\Programme/dbus
> Project MESSAGE: DBUSDIR not specified. Using C:\Programme/dbus
> Project MESSAGE: DBUSDIR not specified. Using C:\Programme/dbus
>   Reading F:/daten/qt-copy/tools/qdbus/tools/tools.pro
>    Reading F:/daten/qt-copy/tools/qdbus/tools/qdbus/qdbus.pro
>
> although the dbus installation dir has to be set by INCLUDE and LIB.

Yes, you're completely right :).

We've removed this from src.pro now and also fixed the build to properly obey 
INCLUDE and LIB from the environment for the mingw build.

In fact I even succeeded to build and /use/ libqtdbus myself on Windows now, 
thanks to your packages and patches :)

I've found another interesting argument in favor of using INCLUDE/LIB, btw: 
It's not only msvc that uses it, the intel compiler supports it, too.


Simon

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]