SVN commit 664964 by apol: fix. Some EBN issues solved M +1 -1 expressionedit.cpp M +1 -1 expressionedit.h M +3 -3 function.cpp M +3 -3 function.h M +1 -1 kalgebra.desktop M +2 -2 object.h --- trunk/kdereview/kalgebra/src/expressionedit.cpp #664963:664964 @@ -367,7 +367,7 @@ ajudant(msg, pos-QPoint(0, 50)); } -void ExpressionEdit::ajudant(const QString& msg, QPoint p) +void ExpressionEdit::ajudant(const QString& msg, const QPoint& p) { if(!msg.isEmpty()){ QFontMetrics fm(m_helptip->font()); --- trunk/kdereview/kalgebra/src/expressionedit.h #664963:664964 @@ -110,7 +110,7 @@ void helpShow(const QString& funcname, int param=0); static QString findPrec(const QString& exp, int &act, int cur, int ¶m, const QString& tit); - void ajudant(const QString&, QPoint p); + void ajudant(const QString&, const QPoint& p); QString lastWord(int); QString editingWord(int pos, int ¶m); void focusInEvent (QFocusEvent * event); --- trunk/kdereview/kalgebra/src/function.cpp #664963:664964 @@ -97,7 +97,7 @@ err << i18n("Too much lambda for a 2D Graph"); } -void function::update_pointsY(QRect viewport, unsigned int max_res) +void function::update_pointsY(const QRect& viewport, unsigned int max_res) { if(viewport.left()==m_last_viewport.left() && viewport.right()==m_last_viewport.right() && max_res==m_last_max_res/* || max_res<=viewport.width()*/) return; @@ -148,7 +148,7 @@ m_last_max_res = max_res; } -void function::update_pointsX(QRect viewport, unsigned int max_res) +void function::update_pointsX(const QRect& viewport, unsigned int max_res) { if(viewport.top()==m_last_viewport.top() && viewport.bottom()==m_last_viewport.bottom() && max_res==m_last_max_res || max_res<=static_cast(-viewport.height())) return; @@ -196,7 +196,7 @@ } -void function::update_pointsPolar(QRect viewport, unsigned int max_res) +void function::update_pointsPolar(const QRect& viewport, unsigned int max_res) { Q_ASSERT(func->expression()->isCorrect()); if(max_res==m_last_max_res && !m_last_viewport.isNull()) --- trunk/kdereview/kalgebra/src/function.h #664963:664964 @@ -115,9 +115,9 @@ unsigned int m_last_resolution; unsigned int m_last_max_res; QStringList err; //function errors - void update_pointsY(QRect viewport, unsigned int resolucio); //for functions such as y=f(x) - void update_pointsX(QRect viewport, unsigned int resolucio); //for functions such as x=f(y) - void update_pointsPolar(QRect viewport, unsigned int resolucio); //for functions such as r=f(sigma) + void update_pointsY(const QRect& viewport, unsigned int resolucio); //for functions such as y=f(x) + void update_pointsX(const QRect& viewport, unsigned int resolucio); //for functions such as x=f(y) + void update_pointsPolar(const QRect& viewport, unsigned int resolucio); //for functions such as r=f(sigma) QPair calc(const QPointF& dp); inline QPointF fromPolar(double r, double th) { return QPointF(r*cos(th), r*sin(th)); } --- trunk/kdereview/kalgebra/src/kalgebra.desktop #664963:664964 @@ -18,6 +18,6 @@ MimeType=application/x-kalgebra Icon=kalgebra Type=Application -#DocPath=kig/index.html +DocPath=kalgebra/index.html Terminal=false Categories=Qt;KDE;Education;Math; --- trunk/kdereview/kalgebra/src/object.h #664963:664964 @@ -93,10 +93,10 @@ bool isContainer() const { return m_type==container; } /** Returns the string representation of the object. */ - virtual QString toString() const { return "object"; }; + virtual QString toString() const = 0; /** Returns the MathML representation of the object. */ - virtual QString toMathML() const { return "object"; }; + virtual QString toMathML() const = 0; /** Converts a @p tag to a type. */ static enum ObjectType whatType(const QString& tag); //FIXME: Needed?