[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/kernel
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2007-05-14 16:56:19
Message-ID: 200705141856.23758.hausmann () kde ! org
[Download RAW message or body]


On Monday 14 May 2007 18:47:18 Urs Wolfer wrote:
> On Monday 14 May 2007, Aaron J. Seigo wrote:
> > SVN commit 664662 by aseigo:
> >
> > default to windows style on windows.
> >
> >
> >  M  +3 -1      kglobalsettings.cpp
> >
> >
> > --- trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp #664661:664662
> > @@ -866,7 +866,9 @@
> >  void KGlobalSettings::applyGUIStyle()
> >  {
> >      KConfigGroup pConfig (KGlobal::config(), "General");
> > -#ifdef Q_WS_MACX
> > +#ifdef Q_WS_WIN
> > +    QString defaultStyle = "windows";
> > +#elif Q_WS_MACX
> >      QString defaultStyle = "macintosh";
> >  #else
> >      QString defaultStyle = QLatin1String("plastique");// =
> > KStyle::defaultStyle(); ### wait for KStyle4
>
> IMHO we should use the windowsxp style on a XP system. But there is a
> problem if the user has an XP system without XP style.. Does Qt
> automtically fallback to the windows style then? Please check. But it looks
> ugly if KDE apps have the "old" windows style on a XP system with the XP
> styles.

Why not let Qt choose the default style on Mac OS X and Windows?

Especially on the latter the XP style isn't the right choice either if you're 
running on Vista for example.

Simon

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]