[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: branches/KDE/3.5/kdegraphics/kolourpaint
From: Clarence Dang <dang () kde ! org>
Date: 2007-05-12 9:33:46
Message-ID: 1178962426.997377.8736.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 663763 by dang:
Check all SYNC's before KDE 3.5.7 release (see branches/kolourpaint/control/TODO for \
what this means). No functional changes where made:
* Change some SYNC to STRING
* Comments
* +TODO
M +5 -5 kolourpaint.cpp
M +2 -1 kolourpaintui.rc
M +2 -1 kpdocumentsaveoptions.cpp
M +1 -0 kpdocumentsaveoptionswidget.cpp
M +15 -15 kpmainwindow_file.cpp
--- branches/KDE/3.5/kdegraphics/kolourpaint/kolourpaint.cpp #663762:663763
@@ -67,8 +67,8 @@
0/*copyright statement - see licence instead*/,
#if 1
0/*free text*/,
-// SYNC: After string freeze, make below the "free text" but point to
-// http://www.kolourpaint.org/support.
+// STRING: After string freeze, make below the "free text" but point to
+// http://www.kolourpaint.org/support.
#else
I18N_NOOP ("Support / Feedback:\n"
"kolourpaint-support@lists.sourceforge.net\n"),
@@ -83,8 +83,8 @@
#if 1
aboutData.setCustomAuthorText (QString::null, QString::null);
-// SYNC: After string freeze, make below the custom author text but point to
-// http://www.kolourpaint.org/support.
+// STRING: After string freeze, make below the custom author text but point to
+// http://www.kolourpaint.org/support.
#else
aboutData.setCustomAuthorText (
I18N_NOOP
@@ -119,7 +119,7 @@
aboutData.addAuthor ("Nuno Pinheiro", I18N_NOOP ("Icons"), \
"nf.pinheiro@gmail.com");
aboutData.addAuthor ("Danny Allen", I18N_NOOP ("Icons"), \
"dannya40uk@yahoo.co.uk"); aboutData.addAuthor ("Martin Koller",
- 0/*SYNC: string freeze prevents us from writing: Scanning \
Support*/, + 0/*STRING: string freeze prevents us from \
writing: Scanning Support*/, "m.koller@surfeu.at");
--- branches/KDE/3.5/kdegraphics/kolourpaint/kolourpaintui.rc #663762:663763
@@ -1,7 +1,8 @@
<!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
<!--
SYNC: Do not change the number of quotes before the version number
- - it is parsed by the KolourPaint wrapper script.
+ - it is parsed by the KolourPaint wrapper shell script (in standalone
+ backport releases of KolourPaint)
-->
<gui name="kolourpaint" version="25">
--- branches/KDE/3.5/kdegraphics/kolourpaint/kpdocumentsaveoptions.cpp #663762:663763
@@ -406,7 +406,8 @@
//
// Run "branches/kolourpaint/control/scripts/gen_mimetype_line.sh Write" in
// the version of kdelibs/kimgio/ (e.g. KDE 3.5) KolourPaint is shipped with,
-// to check for any new mimetypes to add info for.
+// to check for any new mimetypes to add info for. In the methods below,
+// you can specify this info (maximum color depth, whether it's lossy etc.).
//
// Update the below list also and bump up "kpSettingsGroupMimeTypeProperties"
// in kpdefs.h.
--- branches/KDE/3.5/kdegraphics/kolourpaint/kpdocumentsaveoptionswidget.cpp \
#663762:663763 @@ -306,6 +306,7 @@
// Note that we set min to 1 not 0 since "0 Quality" is a bit misleading
// and 101 quality settings would be weird. So we lose 1 quality setting
// according to QImage::save().
+ // TODO: 100 quality is also misleading since that implies perfect quality.
m_qualityInput->setRange (1, 100, 1/*step*/, true/*slider*/);
m_previewButton = new KPushButton (i18n ("&Preview"), this);
--- branches/KDE/3.5/kdegraphics/kolourpaint/kpmainwindow_file.cpp #663762:663763
@@ -432,16 +432,16 @@
#if DEBUG_KP_MAIN_WINDOW
kdDebug () << "\tcould not create scan dialog" << endl;
#endif
- // SYNC: We really need a dialog here. We can't due to string freeze.
- // In order to signal to the user -- without a dialog -- that
- // scanning support is not installed, we disable the action
- // in every window.
+ // STRING: We really need a dialog here. We can't due to string freeze.
+ // In order to signal to the user -- without a dialog -- that
+ // scanning support is not installed, we disable the action
+ // in every window.
//
- // Or we could try to create the scan dialog in the ctor
- // and just disable the action in the first place. But
- // this increases startup time and is also too risky on
- // the stable branch (e.g. if the scan support hangs,
- // KolourPaint would not be able to be started at all).
+ // Or we could try to create the scan dialog in the ctor
+ // and just disable the action in the first place. But
+ // this increases startup time and is also too risky on
+ // the stable branch (e.g. if the scan support hangs,
+ // KolourPaint would not be able to be started at all).
// TODO: PROPAGATE: interprocess
if (KMainWindow::memberList)
@@ -531,8 +531,8 @@
kpDocumentMetaInfo metaInfo;
const QPixmap pixmap = kpDocument::convertToPixmapAsLosslessAsPossible (
image,
- // SYNC: After string freeze, have a custom message about the
- // "scanned image".
+ // STRING: After string freeze, have a custom message about the
+ // "scanned image".
kpMainWindow::pasteWarnAboutLossInfo (),
&saveOptions,
&metaInfo);
@@ -542,9 +542,9 @@
#if DEBUG_KP_MAIN_WINDOW
kdDebug () << "\tcould not convert to pixmap" << endl;
#endif
- // SYNC: After string freeze, we need a message like
- // "out of graphics memory" (see
- // kpDocument::getPixmapFromFile()).
+ // STRING: After string freeze, we need a message like
+ // "out of graphics memory" (see
+ // kpDocument::getPixmapFromFile()).
return;
}
@@ -568,7 +568,7 @@
KImageIO::mimeTypes (KImageIO::Writing)
.findIndex (m_document->saveOptions ()->mimeType ()) < 0 ||
// SYNC: kpDocument::getPixmapFromFile() can't determine quality
- // from file
+ // from file so it has been set initially to an invalid value.
(m_document->saveOptions ()->mimeTypeHasConfigurableQuality () &&
m_document->saveOptions ()->qualityIsInvalid ()) ||
(localOnly && !m_document->url ().isLocalFile ()))
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic