[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/kofficecore
From:       Casper Boemann <cbr () boemann ! dk>
Date:       2007-05-04 12:08:29
Message-ID: 200705041408.29329.cbr () boemann ! dk
[Download RAW message or body]

Adding that to KGlobalSettings would get 95654 stars in my book ;)

On Friday 04 May 2007 14:05, Robert Knight wrote:
> Hello,
>
> Fair point.  The hard-coded limitation can be removed.  If it is
> desireable to have a separate font size for dock widgets that could be
> added as a new setting to KGlobalSettings perhaps?  It could then
> apply to KDevelop, Dolphin and others.
>
> Regards,
> Robert.
>
> On 04/05/07, Stefan Nikolaus <nikolaus4@googlemail.com> wrote:
> > On Friday 04 May 2007 09:20:41 Peter Simonsson wrote:
> > > 2007/5/3, Robert Knight <robertknight@gmail.com>:
> > > > SVN commit 660806 by knight:
> > > >
> > > > Fix the miniscule dock widget fonts.  Please shout if this solution
> > > > is incorrect.
> > > >
> > > >  M  +4 -4      KoMainWindow.cpp
> > > >
> > > >
> > > > --- trunk/koffice/libs/kofficecore/KoMainWindow.cpp #660805:660806
> > > > @@ -1787,12 +1787,12 @@
> > > >
> > > >      KConfigGroup group( KGlobal::config(), "GUI" );
> > > >      QFont f  = KGlobalSettings::generalFont();
> > > > -    double ps = qMin(9.0, f.pointSize() * 0.8);
> > > > -    ps = group.readEntry("palettefontsize", ps);
> > > > -    if (ps < 6) ps = 6;
> > > > +    double ps = group.readEntry("palettefontsize", f.pointSize());
> > > > +    ps = qMax(8.0 , ps);
> > > > +    f.setPointSizeF(ps);
> > > >
> > > > -    f.setPointSize(6);
> > > >      dockWidget->setFont(f);
> > > > +
> > > >      return dockWidget;
> > > >  }
> > >
> > > I don't see the point in setting a max size as you removed the
> > > manipulation of the default font...
> >
> > And I'd like to propose to use KGlobalSettings::toolBarFont() as default
> > and drop any altering of the read-in font size. It's a configure setting:
> > If anyone considers the font too big/tiny, he should change it in the rc
> > file.
> >
> > Regards,
> > Stefan

-- 
best regards / venlig hilsen
Casper Boemann
[prev in list] [next in list] [prev in thread] [next in thread]