[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdegames/libkdegames/digits
From:       "Mark A. Taff" <marktaff () comcast ! net>
Date:       2007-04-22 4:47:03
Message-ID: 200704212147.04737.marktaff () comcast ! net
[Download RAW message or body]

On Saturday 21 April 2007 17:51:02 Pino Toscano wrote:
> -#include <KGameSvgDocument>
> -#include <KSvgRenderer>
> +#include <kgamesvgdocument.h>
> +#include <ksvgrenderer.h>

Pino,

I don't understand this change.  KGameSvgDocument document isn't in the same 
directory as KGameSvgDigits, so it shouldn't be included with double quotes 
per 
http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23includes_right.

And KSvgRenderer isn't part of the same library as libkdegames, so it as well 
should be included with angle brackets per the policy.

That said, you've always been right in the past when it come to situations 
like this, so please, explain to me my error.  Thanks. :-)

Regards,

Mark



[prev in list] [next in list] [prev in thread] [next in thread]