[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeprint
From:       Frerich Raabe <raabe () kde ! org>
Date:       2007-04-16 9:07:26
Message-ID: 200704161107.27059.raabe () kde ! org
[Download RAW message or body]

On Monday 16 April 2007 10:02, Simon Hausmann wrote:
> Don't return a const reference to a QMap.

> -const QMap<QString,QString>& KPrinter::options() const
> +QMap<QString,QString> KPrinter::options() const
>  { return d->m_options; }

Note that code which does

KPrinter p( .. );
for ( QMap<QString, QString>::ConstIterator it = p.options().begin();
	it != p.options().end();
	++it ) {
..
}

might break now.

- Frerich
[prev in list] [next in list] [prev in thread] [next in thread]