[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: qt-copy/tools/qdbus/src
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-04-05 19:38:55
Message-ID: 200704052138.56280.thiago () kde ! org
[Download RAW message or body]


David Faure wrote:
>On Wednesday 04 April 2007, Kevin Ottens wrote:
>> SVN commit 650336 by ervin:
>>
>> Connect to the right slot for error handling.
>>
>>
>>  M  +1 -1      qdbusintegrator.cpp
>>
>>
>> --- trunk/qt-copy/tools/qdbus/src/qdbusintegrator.cpp #650335:650336
>> @@ -1436,7 +1436,7 @@
>>      } else { // use the event loop
>>          QDBusReplyWaiter waiter;
>>          if (sendWithReplyAsync(message, &waiter,
>> SLOT(reply(QDBusMessage)), -                              
>> SLOT(error()), timeout) > 0) { +                              
>> SLOT(error(QDBusError)), timeout) > 0) { // enter the event loop and
>> wait for a reply
>>              waiter.exec(QEventLoop::ExcludeUserInputEvents |
>> QEventLoop::WaitForMoreEvents);
>
>Seems like we see a lot of errors now, indeed...

I wonder how I was getting the code to pass my unit tests without even 
giving a warning about an invalid slot.

I'll test this soon.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]