From kde-commits Wed Mar 21 14:24:20 2007 From: Matthias Kretz Date: Wed, 21 Mar 2007 14:24:20 +0000 To: kde-commits Subject: Re: KDE/kdelibs/kstyles/plastik Message-Id: <200703211524.26881.kretz () kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=117448698422928 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart4165684.yGCBt4ipxd" --nextPart4165684.yGCBt4ipxd Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 20 March 2007 22:34, Nadeem Hasan wrote: > On Tuesday 20 March 2007 04:43:25 pm Matthias Kretz wrote: > > SVN commit 644748 by mkretz: > > > > this should fix a big memleak as QCache::take returns ownership of the > > object to the caller, but the caller didn't delete it. Looking a few > > lines below I think this should be QCache::object instead (i.e. keep the > > object in the cache and keep ownership): > > Does this also apply to the 3.5 branch? You'd have noticed it. This was a leak of 20MB in JuK running for a few=20 minutes. :) Must have been a porting error. =2D-=20 ________________________________________________________ Matthias Kretz (Germany) <>< http://Vir.homelinux.org/ MatthiasKretz@gmx.net, kretz@kde.org, Matthias.Kretz@urz.uni-heidelberg.de --nextPart4165684.yGCBt4ipxd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBGAUAayg4WnCj6OIoRAkg2AJ9ZS1WNPJO/Lvg6WtNN2AfYlfAhBwCgm32+ JWXwCOv5IeDhzFW6K5YGZdU= =h3JE -----END PGP SIGNATURE----- --nextPart4165684.yGCBt4ipxd--