From kde-commits Tue Mar 20 21:34:08 2007 From: Nadeem Hasan Date: Tue, 20 Mar 2007 21:34:08 +0000 To: kde-commits Subject: Re: KDE/kdelibs/kstyles/plastik Message-Id: <200703201734.13996.nhasan () nadmm ! com> X-MARC-Message: https://marc.info/?l=kde-commits&m=117442636128498 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1810460.EAb0LYgqjd" --nextPart1810460.EAb0LYgqjd Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 20 March 2007 04:43:25 pm Matthias Kretz wrote: > SVN commit 644748 by mkretz: > > this should fix a big memleak as QCache::take returns ownership of the > object to the caller, but the caller didn't delete it. Looking a few lines > below I think this should be QCache::object instead (i.e. keep the object > in the cache and keep ownership): Does this also apply to the 3.5 branch? =2D-=20 Nadeem Hasan (nhasan-at-nadmm.com) GPG Fingerprint: 7141 0B1C 9CAF 624D 307F F8EF 6C0C 753E DD3A 0F53 --nextPart1810460.EAb0LYgqjd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGAFNVbAx1Pt06D1MRApcdAKCC7BXVWZHejdXZmmPZUAKpJ0kyzQCdHMce lAqmnozZHCM73n2MFT7JghQ= =8YTh -----END PGP SIGNATURE----- --nextPart1810460.EAb0LYgqjd--