[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kparts
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-03-14 17:11:11
Message-ID: 1173892271.318859.2921.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 642547 by thiago:

ReadWritePart has a private, so it has to initialise it as well.
Otherwise, you'll get crashes everywhere trying to access past the end
of the object.


 M  +6 -1      part.cpp  
 M  +3 -0      part.h  


--- trunk/KDE/kdelibs/kparts/part.cpp #642546:642547
@@ -417,6 +417,11 @@
 {
 }
 
+ReadOnlyPart::ReadOnlyPart( ReadOnlyPartPrivate &dd, QObject *parent )
+  : Part( dd, parent )
+{
+}
+
 ReadOnlyPart::~ReadOnlyPart()
 {
   ReadOnlyPart::closeUrl();
@@ -623,7 +628,7 @@
 
 
 ReadWritePart::ReadWritePart( QObject *parent )
- : ReadOnlyPart( parent )
+  : ReadOnlyPart( *new ReadWritePartPrivate(this), parent )
 {
 }
 
--- trunk/KDE/kdelibs/kparts/part.h #642546:642547
@@ -582,6 +582,9 @@
    */
   void setLocalFilePath( const QString &localFilePath );
 
+protected:
+    ReadOnlyPart(ReadOnlyPartPrivate &dd, QObject *parent);
+
 private:
   Q_PRIVATE_SLOT(d_func(), void _k_slotJobFinished( KJob * job ))
 
[prev in list] [next in list] [prev in thread] [next in thread]