[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdepim/kmail
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2007-03-12 12:37:27
Message-ID: 200703121337.31104.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Monday 12 March 2007, Dirk Mueller wrote:
>  void KMMainWidget::readPreConfig(void)
>  {
> -  const KConfigGroup geometry( KMKernel::config(), "Geometry" );
> -  const KConfigGroup general( KMKernel::config(), "General" );
> +  KConfigGroup geometry( KMKernel::config(), "Geometry" );
> +  KConfigGroup general( KMKernel::config(), "General" );
> +  KConfigGroup reader( KMKernel::config(), "Reader" );

Why did you remove the const? Const local objects are very good practice.
I'll send a Marc Mutz at you if needed :-P
 
>    mLongFolderList = geometry.readEntry( "FolderList", "long" ) != "short";
>    mReaderWindowActive = geometry.readEntry( "readerWindowMode", "below" ) != "hide";
>    mReaderWindowBelow = geometry.readEntry( "readerWindowMode", "below" ) == "below";
> +  mThreadPref = geometry.readBoolEntry( "nestedMessages", false );
> +
> +  mHtmlPref = reader.readBoolEntry( "htmlMail", false );
> +  mHtmlLoadExtPref = reader.readBoolEntry( "htmlLoadExternal", false );
>  }

The "general" KConfigGroup doesn't seem to be used btw (both before and after this patch).

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]