[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdepim/kmail
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2007-03-04 21:24:27
Message-ID: 1173043467.411900.31069.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 639336 by mkoller:

BUG: 79685

By default, honor umask of the user when saving attachments,
but offer a config entry (without user interface) for those
who explicitely don't like that
([General] section, disregardUmask boolean)


 M  +4 -0      kmail.kcfg  
 M  +5 -1      kmcommands.cpp  


--- branches/KDE/3.5/kdepim/kmail/kmail.kcfg #639335:639336
@@ -87,6 +87,10 @@
     </group>
 
     <group name="General">
+      <entry name="disregardUmask" type="Bool">
+        <label>Disregard the users umask setting and use "read-write for the user only" instead</label>
+        <default>false</default>
+      </entry>
       <entry name="SystemTrayEnabled" type="Bool">
         <label>Enable system tray icon</label>
         <default>false</default>
--- branches/KDE/3.5/kdepim/kmail/kmcommands.cpp #639335:639336
@@ -2627,7 +2627,11 @@
           i18n( "KMail Error" ) );
       return Failed;
     }
-    fchmod( file.handle(), S_IRUSR | S_IWUSR );
+
+    // #79685 by default use the umask the user defined, but let it be configurable
+    if ( GlobalSettings::self()->disregardUmask() )
+      fchmod( file.handle(), S_IRUSR | S_IWUSR );
+
     ds.setDevice( &file );
   } else
   {
[prev in list] [next in list] [prev in thread] [next in thread]