[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeedu/libkdeedu/kdeeducore
From:       Pino Toscano <toscano.pino () tiscali ! it>
Date:       2007-02-28 23:21:18
Message-ID: 1172704878.972879.28904.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 638143 by pino:

misc stuff, like explicit for constructors, constness, pass-by-const-ref, etc


 M  +1 -1      keduvocdocument.cpp  
 M  +1 -1      keduvocdocument.h  
 M  +2 -2      keduvocexpression.h  
 M  +1 -1      keduvocpaukerreader.cpp  
 M  +1 -1      leitnerbox.cpp  
 M  +2 -2      leitnerbox.h  


--- trunk/KDE/kdeedu/libkdeedu/kdeeducore/keduvocdocument.cpp #638142:638143
@@ -856,7 +856,7 @@
 }
 
 
-void KEduVocDocument::setLessonsInQuery(QList<int> lesson_iq)
+void KEduVocDocument::setLessonsInQuery(const QList<int> &lesson_iq)
 {
   d->m_lessonsInQuery.clear();
   for (int i = 0; i < d->m_lessonDescriptions.count(); i++)
--- trunk/KDE/kdeedu/libkdeedu/kdeeducore/keduvocdocument.h #638142:638143
@@ -657,7 +657,7 @@
   /**
    * Sets the lessons in the current query
    */
-  void setLessonsInQuery(QList<int>);
+  void setLessonsInQuery(const QList<int> &lesson_iq);
 
   QStringList lessonDescriptions() const;
 
--- trunk/KDE/kdeedu/libkdeedu/kdeeducore/keduvocexpression.h #638142:638143
@@ -70,14 +70,14 @@
 
   /** default constructor for an empty vocabulary expression
    */
-  KEduVocExpression();
+  explicit KEduVocExpression();
 
   /** Constructor for a vocabulary expression with an original
    *
    * @param expression       original
    * @param lesson           lesson number, 0 for none
    */
-  KEduVocExpression(const QString & expression, int lesson = 0);
+  explicit KEduVocExpression(const QString & expression, int lesson = 0);
 
   /** Constructor for a vocabulary expression with an original and one or more translations
    *
--- trunk/KDE/kdeedu/libkdeedu/kdeeducore/keduvocpaukerreader.cpp #638142:638143
@@ -75,6 +75,6 @@
   if(!element.isNull())
     return element.text();
   else
-    return QString::null;
+    return QString();
 }
 
--- trunk/KDE/kdeedu/libkdeedu/kdeeducore/leitnerbox.cpp #638142:638143
@@ -20,7 +20,7 @@
 {
 }
 
-int LeitnerBox::vocabCount()
+int LeitnerBox::vocabCount() const
 {
 	return m_vocabCount;
 }
--- trunk/KDE/kdeedu/libkdeedu/kdeeducore/leitnerbox.h #638142:638143
@@ -39,7 +39,7 @@
 	/**
 	 * The constructor
 	 */
-	LeitnerBox();
+	explicit LeitnerBox();
 
 	/**
 	 * The destructor
@@ -81,7 +81,7 @@
 	 * Returns the current vocabCount
 	 * @return the number of cards/ vocabs that are currently assigned to the LeitnerBox.
 	 */
-	int vocabCount();
+	int vocabCount() const;
 
 	/**
 	 * Returns a pointer to the LeitnerBox correct cards of this LeitnerBox here are assigned to
[prev in list] [next in list] [prev in thread] [next in thread]