[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/cmake/modules
From:       David Faure <faure () kde ! org>
Date:       2007-02-28 21:20:37
Message-ID: 200702282220.38401.faure () kde ! org
[Download RAW message or body]

On Wednesday 28 February 2007, Alexander Neundorf wrote:
> On Wednesday 28 February 2007 21:35, Dirk Mueller wrote:
> > SVN commit 638102 by mueller:
> > 
> > fix X11 detection again. Whats the point of not searching
> > X11 in /usr/include, when it is actually installed there
> > for almost all newer distros?
> 
> By default these directories are searched automatically by cmake, so they 
> don't have to be listed explicitely.
> 
> David added the NO_SYSTEM_PATH (which is deprecated by NO_DEFAULT_PATH) for 
> the FIND_LIBRARY() calls for speed reasons:
> http://websvn.kde.org/trunk/KDE/kdelibs/cmake/modules/FindX11.cmake?r1=536135&r2=536154
> 
(Summary: FIND_LIBRARY looks into -all- of $PATH otherwise! A rather strange \
behavior, since libs are never in bin dirs on unix)

> So either we should use NO_DEFAULT_PATH also for the headers and put the 
> default dirs also in the list
I don't see why; looking in /usr/include automatically is fine. As long as looking \
for headers doesn't mean looking into all of $PATH...

> or we remove the NO_SYSTEM_PATH for the FIND_LIBRARY() and then remove also the \
> default directories.
Please don't.

I think your followup means: both should use the same mechanism (NO_SYSTEM_PATH or \
not), but I'm not sure they should, since the 'system paths' are quite different for \
libs and headers.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]