[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/html
From:       Harri Porten <porten () kde ! org>
Date:       2007-02-25 1:04:49
Message-ID: 1172365489.676449.15545.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 637013 by porten:

value() for radio button and checkboxes works on the value
attribute. setValue() should do so then. See WebCore
patch 7814 (incomplete back then) for more info.

Fixes bug #127533 and possibly others.


 M  +4 -0      html_formimpl.cpp  


--- branches/KDE/3.5/kdelibs/khtml/html/html_formimpl.cpp #637012:637013
@@ -1738,6 +1738,10 @@
     if (m_type == FILE) return;
 
     m_value = (val.isNull() ? DOMString("") : val);
+    // ### set attribute for other types, too. no need for m_value
+    // ### in those cases.
+    if (m_type == RADIO || m_type == CHECKBOX)
+	setAttribute(ATTR_VALUE, m_value);
     if (m_type == TEXT && m_render)
         m_render->updateFromElement();
     setChanged();
[prev in list] [next in list] [prev in thread] [next in thread]