[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/kdepim-3.5.5+/libkhalkhi/control
From:       Friedrich W. H. Kossebau <kossebau () kde ! org>
Date:       2007-02-23 13:45:44
Message-ID: 1172238344.475850.32401.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 636591 by kossebau:

fix: delete dialog always (memleak), use service name for title

 M  +3 -3      branches/work/kdepim-3.5.5+/libkhalkhi/control/kservicelistitem.cpp  


--- branches/work/kdepim-3.5.5+/libkhalkhi/control/kservicelistitem.cpp \
#636590:636591 @@ -43,7 +43,7 @@
 {
     bool Result = false;
 
-    ServiceConfigDialog *Dialog = new ServiceConfigDialog( Parent, \
configLibrary(Service) ); +    ServiceConfigDialog *Dialog = new ServiceConfigDialog( \
Parent, Service->name() );  
     QWidget *ConfigWidget =
         KParts::ComponentFactory::createInstanceFromLibrary<QWidget>( \
configLibrary(Service).local8Bit().data(), Dialog ); @@ -54,10 +54,10 @@
 
         if( Dialog->exec() == QDialog::Accepted )
             Result = Dialog->isDirty();
-
-        delete Dialog;
     }
 
+    delete Dialog;
+
     return Result;
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]