[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebindings/qtruby/rubylib/qtruby
From:       Richard Dale <Richard_Dale () tipitina ! demon ! co ! uk>
Date:       2007-02-14 15:06:09
Message-ID: 1171465569.825709.3645.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 633609 by rdale:

* Fix dodgy use of Ruby string contents by strdup'ing it



 M  +4 -2      Qt.cpp  


--- trunk/KDE/kdebindings/qtruby/rubylib/qtruby/Qt.cpp #633608:633609
@@ -2951,7 +2951,7 @@
 static VALUE
 create_qobject_class(VALUE /*self*/, VALUE package_value)
 {
-	const char *package = StringValuePtr(package_value);
+	const char *package = strdup(StringValuePtr(package_value));
 	VALUE klass;
 	
 	QString packageName(package);
@@ -3019,13 +3019,14 @@
 	rb_define_method(klass, "connect", (VALUE (*) (...)) qobject_connect, -1);   
 	rb_define_singleton_method(klass, "connect", (VALUE (*) (...)) qobject_connect, -1);   
 
+	free((void *) package);
 	return klass;
 }
 
 static VALUE
 create_qt_class(VALUE /*self*/, VALUE package_value)
 {
-	const char *package = StringValuePtr(package_value);
+	const char *package = strdup(StringValuePtr(package_value));
 	VALUE klass;
 	QString packageName(package);
 	
@@ -3076,6 +3077,7 @@
 		rb_define_method(klass, "internalPointer", (VALUE (*) (...)) qmodelindex_internalpointer, 0);
 	}
 
+	free((void *) package);
 	return klass;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]